Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-11163] Support for a consumable notifications capability #4259

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

mdimjasevic
Copy link
Contributor

Tracked by https://wearezeta.atlassian.net/browse/WPB-11163.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Sep 19, 2024
@mdimjasevic
Copy link
Contributor Author

@akshaymankar , this touches the client API. Should we make the change versioned?

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 19, 2024
@akshaymankar akshaymankar force-pushed the wpb-11163/consumable-notifications-capability branch 2 times, most recently from bc1797f to 8b6fee3 Compare September 23, 2024 14:24
Copy link
Contributor

@MangoIV MangoIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to @fisx and me :)

@MangoIV MangoIV force-pushed the wpb-11163/consumable-notifications-capability branch from 28dcff7 to 4458e14 Compare September 24, 2024 08:09
@fisx fisx merged commit 264445c into develop Sep 24, 2024
10 checks passed
@fisx fisx deleted the wpb-11163/consumable-notifications-capability branch September 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants