[chore] Expose record accessors for Brig.App.Env. #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
This reduces lens usage to mostly the cases where we want lens functionality, instead of record accessor functionality.
elland
force-pushed
the
chore/reduce-lens-usage-brig-env
branch
from
955136b
to
014213d
Compare
elland
added
the
echoes: maintenance
pcapriotti
approved these changes
Sep 19, 2024
elland
added
echoes: technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces lens usage to mostly the cases where we want lens functionality, instead of record accessor functionality.
Brig.Options parsing has been modified, there are fields that could be set but currently are not set anywhere in our config yamls, which could cause breakage if we have deployments relying on them. Might be worth coming back and ensuring we test every field.