-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip step better UI #4465
Merged
Merged
skip step better UI #4465
+55
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 27fd736 in 47 seconds
More details
- Looked at
243
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. backend/windmill-worker/src/worker_flow.rs:702
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to multiple places in the codebase, including theFlowStatusModule
struct and its serialization/deserialization logic. However, theskipped
field is not being used consistently across all relevant parts of the codebase.
2. frontend/src/lib/components/FlowStatusViewerInner.svelte:441
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
3. frontend/src/lib/components/ModuleStatus.svelte:10
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
4. frontend/src/lib/components/flows/map/FlowModuleSchemaItem.svelte:37
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
5. frontend/src/lib/components/flows/map/MapItem.svelte:51
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
6. frontend/src/lib/components/graph/model.ts:63
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
7. frontend/src/lib/components/graph/renderers/nodes/ModuleNode.svelte:59
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
8. frontend/src/lib/components/graph/util.ts:16
- Draft comment:
Ensure that theskipped
field is consistently used across all relevant parts of the codebase. It is currently being added to theFlowStatusModule
struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked. - Reason this comment was not posted:
Confidence changes required:50%
Theskipped
field is being added to theFlowStatusModule
struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
Workflow ID: wflow_noGNIUf5cY0UyEDb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add 'skipped' status to flow modules, updating backend logic, frontend UI, and API schema.
skipped
field toFlowStatusModule
inflow_status.rs
andworker_flow.rs
.update_flow_status_after_job_completion_internal()
inworker_flow.rs
to setskipped
based on job kind.skipped
property toModuleStatus.svelte
andFlowStatusViewerInner.svelte
.getStateColor()
inutil.ts
to change color for skipped modules.FlowModuleSchemaItem.svelte
andMapItem.svelte
.skipped
field toFlowStatusModule
inopenflow.openapi.yaml
.This description was created by for 27fd736. It will automatically update as commits are pushed.