Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip step better UI #4465

Merged
merged 1 commit into from
Oct 1, 2024
Merged

skip step better UI #4465

merged 1 commit into from
Oct 1, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Oct 1, 2024

Important

Add 'skipped' status to flow modules, updating backend logic, frontend UI, and API schema.

  • Backend:
    • Add skipped field to FlowStatusModule in flow_status.rs and worker_flow.rs.
    • Update update_flow_status_after_job_completion_internal() in worker_flow.rs to set skipped based on job kind.
  • Frontend:
    • Add skipped property to ModuleStatus.svelte and FlowStatusViewerInner.svelte.
    • Update getStateColor() in util.ts to change color for skipped modules.
    • Add skip icon to FlowModuleSchemaItem.svelte and MapItem.svelte.
  • API:
    • Add skipped field to FlowStatusModule in openflow.openapi.yaml.

This description was created by Ellipsis for 27fd736. It will automatically update as commits are pushed.

@rubenfiszel rubenfiszel merged commit b70ca6e into main Oct 1, 2024
2 of 4 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 27fd736 in 47 seconds

More details
  • Looked at 243 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. backend/windmill-worker/src/worker_flow.rs:702
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to multiple places in the codebase, including the FlowStatusModule struct and its serialization/deserialization logic. However, the skipped field is not being used consistently across all relevant parts of the codebase.
2. frontend/src/lib/components/FlowStatusViewerInner.svelte:441
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
3. frontend/src/lib/components/ModuleStatus.svelte:10
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
4. frontend/src/lib/components/flows/map/FlowModuleSchemaItem.svelte:37
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
5. frontend/src/lib/components/flows/map/MapItem.svelte:51
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
6. frontend/src/lib/components/graph/model.ts:63
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
7. frontend/src/lib/components/graph/renderers/nodes/ModuleNode.svelte:59
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.
8. frontend/src/lib/components/graph/util.ts:16
  • Draft comment:
    Ensure that the skipped field is consistently used across all relevant parts of the codebase. It is currently being added to the FlowStatusModule struct and its serialization/deserialization logic, but make sure it is also used wherever the flow status is updated or checked.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The skipped field is being added to the FlowStatusModule struct and its serialization/deserialization logic. However, it is not being used consistently across all relevant parts of the codebase.

Workflow ID: wflow_noGNIUf5cY0UyEDb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel deleted the hc/skip-step-ui branch October 1, 2024 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants