Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flow step skipping #4461

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: flow step skipping #4461

merged 1 commit into from
Sep 30, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Sep 30, 2024

Important

Add skip_if feature to allow conditional skipping of flow steps, with backend logic, frontend UI, and OpenAPI spec updates.

  • Backend:
    • Add skip_if property to FlowModule in windmill-common/src/flows.rs.
    • Implement logic in push_next_flow_job() in windmill-worker/src/worker_flow.rs to evaluate skip_if condition and skip steps if true.
  • Frontend:
    • Add FlowModuleSkip.svelte component for UI to set skip_if condition.
    • Update FlowBranchesAllWrapper.svelte, FlowBranchesOneWrapper.svelte, FlowLoop.svelte, FlowModuleComponent.svelte, FlowWhileLoop.svelte, and FlowModuleWrapper.svelte to include FlowModuleSkip.
  • OpenAPI:
    • Update openflow.openapi.yaml to include skip_if property in FlowModule schema.

This description was created by Ellipsis for 6a84be5. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6a84be5 in 1 minute and 3 seconds

More details
  • Looked at 548 lines of code in 13 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_U1kfFGeVNlRsYGnL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a84be5
Status: ✅  Deploy successful!
Preview URL: https://547017df.windmill.pages.dev
Branch Preview URL: https://hugo-win-409-skip-predicate.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 0df169e into main Sep 30, 2024
4 checks passed
@rubenfiszel rubenfiszel deleted the hugo/win-409-skip-predicate branch September 30, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants