Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 1.394.5 #4385

Merged

Conversation

rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented Sep 13, 2024

🤖 I have created a release beep boop

1.394.5 (2024-09-13)

Bug Fixes


This PR was generated with Release Please. See documentation.


🚀 This description was created by Ellipsis for commit 0ed5c54

chore(main): release 1.394.5

Summary:

Release 1.394.5 includes bug fixes for S3 uploads, parquet renderer, queue metrics, and internal scripts.

Key points:

  • Release 1.394.5: Bug fixes for S3 uploads, parquet renderer, queue metrics, and internal scripts.
  • Version Update: Updated version.txt to 1.394.5.
  • Changelog Update: Updated CHANGELOG.md with bug fixes for version 1.394.5.
  • Bug Fixes:
    • Add filename to S3 upload (11ca14a).
    • Display number of rows in parquet renderer (#4389).
    • Fix queue metrics graph (#4388).
    • Update internal hub scripts to use bun (#4384).

Generated with ❤️ by ellipsis.dev

Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e753cf
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8566e5c in 10 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be consistent with the changelog and PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.394.5, matching the release version in the PR description and changelog.

Workflow ID: wflow_ZxyeZcMwMDSOR0mU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 1688c8e to 7f043c8 Compare September 13, 2024 09:53
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7f043c8 in 12 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.394.5 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been correctly updated to 1.394.5, matching the release version in the PR description.

Workflow ID: wflow_PG5nJmPASyo6ohMk


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from f3e7a70 to d999b18 Compare September 13, 2024 15:50
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d999b18 in 14 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version number has been correctly updated to 1.394.5 to match the release version.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version.txt file has been updated correctly to reflect the new version number 1.394.5. This matches the intended release version in the PR description.

Workflow ID: wflow_CgU8sFhfl6kJo11S


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from f0b94f2 to 54b7262 Compare September 13, 2024 21:36
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 54b7262 to 0ed5c54 Compare September 13, 2024 21:36
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 54b7262 in 18 seconds

More details
  • Looked at 28 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version number has been correctly updated to 1.394.5, matching the release version in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been correctly updated to 1.394.5, matching the release version in the PR description. This is a standard change for a release PR.

Workflow ID: wflow_FLFijJvIh2HgjmYb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0ed5c54 in 32 seconds

More details
  • Looked at 28 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version number should not have a line prefix. It should be just 1.394.5.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is addressing a potential issue with the format of the version number, which is relevant to the change made in the diff. The presence of 'L1:' before the version number could be a formatting error. The comment is actionable as it suggests a specific change to the format.
    I might be missing context about whether 'L1:' is an intentional part of the versioning system. However, the comment is about a change in the diff, so it is relevant.
    Even if 'L1:' is intentional, the comment is still relevant because it addresses a change in the diff. The comment is actionable and clear.
    Keep the comment as it addresses a potential formatting issue with the version number that is relevant to the change made in the diff.

Workflow ID: wflow_4bpgEc4MymP3ApL1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 2e80107 into main Sep 13, 2024
1 check was pending
@rubenfiszel rubenfiszel deleted the release-please--branches--main--components--windmill branch September 13, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
@rubenfiszel
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant