Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodesettingschanges #53

Merged
merged 6 commits into from
May 25, 2014
Merged

nodesettingschanges #53

merged 6 commits into from
May 25, 2014

Conversation

stargazerwna
Copy link
Contributor

test nodesettingschanges

ysamouhos added a commit that referenced this pull request May 25, 2014
Merged nodesettingschanges addition from stargazer.
@ysamouhos ysamouhos merged commit 2d4e1be into wind-project:master May 25, 2014
@sque
Copy link
Member

sque commented May 25, 2014

stargazer, nice to see making pull requests :)
First of all, what is this pull request for? What does exactly changes? Is there any relevant issue that i fixes?

Ysam, plz stop merging! We agreed to do it two persons for the sake of code consistency... I don't like enforcement policies (user permissions) so please respect this. You bypass code reviews...


);

?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for? modified/greek.php
It seems to be committed by mistake. Is it?

@ysamouhos
Copy link
Member

Doing the changes myself.

@sque
Copy link
Member

sque commented May 25, 2014

This is very nice of you, but I think stargazer is a very capable programmer to know how to make these changes. He should also be given the opportunity to question the code reviews. Maybe he has something better to propose.

@ysamouhos
Copy link
Member

For sure. On next commit he will, now that he knows.

@stargazerwna
Copy link
Contributor Author

@sque #47

@ysamouhos Thank you :)

@acinonyx
Copy link
Contributor

http://en.wikipedia.org/wiki/Good_cop/bad_cop

@ysamouhos
Copy link
Member

:)

@jbonicioli
Copy link
Contributor

Cops are not always involved lol
http://en.wikipedia.org/wiki/Bipolar_disorder

@stargazerwna
Copy link
Contributor Author

...

Λεωνίδας Παπαδόπουλος

Sent from my iPad

28 Μαϊ 2014, 12:18, ο/η jbonicioli [email protected] έγραψε:

Cops are not always involved lol
http://en.wikipedia.org/wiki/Bipolar_disorder


Reply to this email directly or view it on
GitHubhttps://github.com//pull/53#issuecomment-44382557
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants