fix: cast variables (#192)

wilr · Oct 27, 2023 · def6be3 · def6be3
1 parent 523d196
commit def6be3
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/GoogleSitemap.php b/src/GoogleSitemap.php
@@ -236,7 +236,8 @@ public static function clear_registered_routes()
      */
     public function getItems($class, $page = 1)
     {
-        //normalise the class name
+        $page = (int) $page;
+
         try {
             $reflectionClass = new ReflectionClass($class);
             $class = $reflectionClass->getName();
@@ -246,9 +247,9 @@ public function getItems($class, $page = 1)
         }
 
         $output = new ArrayList();
-        $count = Config::inst()->get(__CLASS__, 'objects_per_sitemap');
-        $filter =  Config::inst()->get(__CLASS__, 'use_show_in_search');
-        $redirector =  Config::inst()->get(__CLASS__, 'exclude_redirector_pages');
+        $count = (int) Config::inst()->get(__CLASS__, 'objects_per_sitemap');
+        $filter = Config::inst()->get(__CLASS__, 'use_show_in_search');
+        $redirector = Config::inst()->get(__CLASS__, 'exclude_redirector_pages');
 
         // todo migrate to extension hook or DI point for other modules to
         // modify state filters
@@ -416,7 +417,7 @@ public function getSitemaps()
                         ->limit($countPerFile, ($i - 1) * $countPerFile)
                         ->last();
 
-                    $lastModified = ($sliced) ? date('Y-m-d', strtotime($sliced->LastEdited)): date('Y-m-d');
+                    $lastModified = ($sliced) ? date('Y-m-d', strtotime($sliced->LastEdited)) : date('Y-m-d');
 
                     $sitemaps->push(new ArrayData(array(
                         'ClassName' => $this->sanitiseClassName($class),