Weighted densities support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
reviewed
Feb 6, 2024
| gg_no_wts <- layer_data(ggplot(df, aes(x = x, y = 0)) + stat_density_ridges()) | ||
| d_no_wts <- stats::density(df$x) | ||
|
|
||
| expect_equal(gg_no_wts$density,d_no_wts$y) |
There was a problem hiding this comment.
Please always put a space after a comma (there are a few more cases like that in the following lines).
|
This generally looks good to me. Could you also make an entry in |
|
Thanks for the quick turnaround! Let me know if there's anything else I need to clean up! |
|
Thanks for your contribution! I just recently made a release, so not sure how quickly this will percolate to CRAN. But at least it's in the github version now. |
This was referenced Feb 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resurrect PR59 from @mkoohafkan.
I tried to address the notes on the original PR, narrowing the focus to just adding the weight aesthetic and adding two tests, one for the unweighted density case and one for the weighted case.