Skip to content

Commit

Permalink
Update Wikibase CSS to LESS to support theme variables
Browse files Browse the repository at this point in the history 
For better maintainability and easier implementation of dark mode
in Wikibase, convert (move) CSS files to be LESS files so that
variables from the skin can be used throughout.

Bug: T369385
Change-Id: I8ccc888b5d67b8f71414c807a54106cd7d1bcf95
  • Loading branch information
@codders
codders committed Oct 21, 2024
1 parent 191a2e1 commit 03bfeb7
Show file tree
Hide file tree
Showing 21 changed files with 39 additions and 39 deletions.
4 changes: 2 additions & 2 deletions repo/resources/Resources.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@
],
],
'styles' => [
'view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.css',
'view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css',
'view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbaritem.less',
'view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.less',
],
'dependencies' => [
'mediawiki.api',
Expand Down
72 changes: 36 additions & 36 deletions view/resources.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
'jquery/wikibase/jquery.wikibase.entityselector.js',
],
'styles' => [
'jquery/wikibase/themes/default/jquery.wikibase.entityselector.css',
'jquery/wikibase/themes/default/jquery.wikibase.entityselector.less',
],
'dependencies' => [
'jquery.event.special.eachchange',
Expand All @@ -82,8 +82,8 @@

'jquery.wikibase.toolbar.styles' => $moduleTemplate + [
'styles' => [
'jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbar.css',
'jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbarbutton.css',
'jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbar.less',
'jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbarbutton.less',
],
],

Expand All @@ -101,26 +101,26 @@
'wikibase.desktop' => $moduleTemplate + [
'styles' => [
'wikibase/wikibase.less',
'jquery/wikibase/themes/default/jquery.wikibase.aliasesview.css',
'jquery/wikibase/themes/default/jquery.wikibase.aliasesview.less',
'jquery/wikibase/themes/default/jquery.wikibase.descriptionview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entityview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.css',
'jquery/wikibase/themes/default/jquery.wikibase.labelview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.css',
'jquery/wikibase/themes/default/jquery.wikibase.statementgroupview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.less',
'jquery/wikibase/themes/default/jquery.wikibase.labelview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.less',
'jquery/wikibase/themes/default/jquery.wikibase.statementgroupview.less',
],
],

// mobile-only
'wikibase.mobile' => $moduleTemplate + [
'styles' => [
'wikibase/wikibase.mobile.css',
'jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css',
'jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.less',
],
],

Expand All @@ -130,19 +130,19 @@
// Order must be hierarchical, do not order alphabetically
'wikibase/wikibase.less',
'wikibase/wikibase.itemlink.less',
'jquery/wikibase/themes/default/jquery.wikibase.aliasesview.css',
'jquery/wikibase/themes/default/jquery.wikibase.aliasesview.less',
'jquery/wikibase/themes/default/jquery.wikibase.descriptionview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entityview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.css',
'jquery/wikibase/themes/default/jquery.wikibase.labelview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.css',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.less',
'jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.less',
'jquery/wikibase/themes/default/jquery.wikibase.labelview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.less',
'wikibase/wikibase.badgedisplay.less',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.css',
'jquery/wikibase/themes/default/jquery.wikibase.statementgroupview.css',
'jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.less',
'jquery/wikibase/themes/default/jquery.wikibase.statementgroupview.less',
],
],

Expand Down Expand Up @@ -274,22 +274,22 @@
'resources/wikibase/utilities/wikibase.utilities.ui.js',
],
'styles' => [
'resources/jquery/wikibase/themes/default/jquery.wikibase.badgeselector.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.mw-collapsible.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.labelview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.badgeselector.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinklistview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.mw-collapsible.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgroupview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.labelview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.descriptionview.less',
'resources/jquery/ui/jquery.ui.tagadata.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.aliasesview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.aliasesview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsview.less',
'resources/jquery/wikibase/themes/default/jquery.wikibase.mw-pulsating-dot.less',
'resources/jquery/wikibase/snakview/themes/default/snakview.SnakTypeSelector.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.less',
'lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.toggler.css',
'resources/jquery/wikibase/themes/default/jquery.wikibase.entityview.less',
'resources/wikibase/utilities/wikibase.utilities.ui.css',
Expand Down
0 ...s/default/jquery.wikibase.aliasesview.css → .../default/jquery.wikibase.aliasesview.less
View file
File renamed without changes.
0 ...default/jquery.wikibase.badgeselector.css → ...efault/jquery.wikibase.badgeselector.less
View file
File renamed without changes.
0 ...efault/jquery.wikibase.entityselector.css → ...fault/jquery.wikibase.entityselector.less
View file
File renamed without changes.
0 ...kibase.entitytermsforlanguagelistview.css → ...ibase.entitytermsforlanguagelistview.less
View file
File renamed without changes.
0 ...y.wikibase.entitytermsforlanguageview.css → ....wikibase.entitytermsforlanguageview.less
View file
File renamed without changes.
0 ...fault/jquery.wikibase.entitytermsview.css → ...ault/jquery.wikibase.entitytermsview.less
View file
File renamed without changes.
0 ...mes/default/jquery.wikibase.labelview.css → ...es/default/jquery.wikibase.labelview.less
View file
File renamed without changes.
0 ...jquery.wikibase.sitelinkgrouplistview.css → ...query.wikibase.sitelinkgrouplistview.less
View file
File renamed without changes.
0 ...ult/jquery.wikibase.sitelinkgroupview.css → ...lt/jquery.wikibase.sitelinkgroupview.less
View file
File renamed without changes.
0 ...base.sitelinkgroupview.mw-collapsible.css → ...ase.sitelinkgroupview.mw-collapsible.less
View file
File renamed without changes.
0 ...ault/jquery.wikibase.sitelinklistview.css → ...ult/jquery.wikibase.sitelinklistview.less
View file
File renamed without changes.
0 .../default/jquery.wikibase.sitelinkview.css → ...default/jquery.wikibase.sitelinkview.less
View file
File renamed without changes.
0 ...lt/jquery.wikibase.statementgroupview.css → ...t/jquery.wikibase.statementgroupview.less
View file
File renamed without changes.
0 ...y.wikibase.statementview.RankSelector.css → ....wikibase.statementview.RankSelector.less
View file
File renamed without changes.
0 ...s/default/jquery.wikibase.edittoolbar.css → .../default/jquery.wikibase.edittoolbar.less
View file
File renamed without changes.
0 ...hemes/default/jquery.wikibase.toolbar.css → ...emes/default/jquery.wikibase.toolbar.less
View file
File renamed without changes.
0 ...default/jquery.wikibase.toolbarbutton.css → ...efault/jquery.wikibase.toolbarbutton.less
View file
File renamed without changes.
0 ...s/default/jquery.wikibase.toolbaritem.css → .../default/jquery.wikibase.toolbaritem.less
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion view/resources/wikibase/wikibase.badgedisplay.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Badge styles for desktop and mobile:
* used in wikibase-sitelinkview, but also Special:AvailableBadges.
*
* Note that jquery.wikibase.sitelinkview.css has another style for the empty badge,
* Note that jquery.wikibase.sitelinkview.less has another style for the empty badge,
* which is only shown when editing and not needed on Special:AvailableBadges.
*
* @license GNU GPL v2+
Expand Down

0 comments on commit 03bfeb7

Please sign in to comment.