Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary redirects to their targets #38

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

aaronliu0130
Copy link

No description provided.

@aaronliu0130
Copy link
Author

It appears I'll need to update the tests later.

@aaronliu0130
Copy link
Author

BTW, there seem to be no tests for merging

Could this use the "Squash and merge" button? Thanks!

@NovemLinguae
Copy link
Member

It didn't auto run the tests for some reason. Maybe because this is your first patch to the repo.

Unit tests failed for this patchset, it looks like. You can run them locally with npm ci then npm test

@aaronliu0130
Copy link
Author

aaronliu0130 commented Jun 3, 2024

Sorry, I"m on my mobile device rn!

For "merging" I meant merging articles

skipping since it seems to fail and hopefully merging will fix teh tests
@aaronliu0130
Copy link
Author

Yeah, this did introduced some substantial issues. Going to look into it.

@aaronliu0130
Copy link
Author

Sorry, I'm a bit new to this. Is there some flag that allows the current behavior of extensionless import resolution I'm missing? Building and running works but debugging with the node command doesn't.

@NovemLinguae
Copy link
Member

extensionless import resolution

I'm not sure what this is. Are you saying that npm test isn't working for you? Is it giving an error message you can share?

@aaronliu0130
Copy link
Author

VSCode gives me err_module_not_found when I attempt to debug after adding "type":"module" to package.json (otherwise i get "SyntaxError: Cannot use import statement outside a module") because the imports lack file extensions

@NovemLinguae
Copy link
Member

NovemLinguae commented Jun 4, 2024

Are you just trying to step debug through one of the tests? Try replacing your /.vscode/launch.json with this. When you hit the play button in the VS Code debugger, it should run the tests and hit your breakpoint after 30 seconds or so (it takes awhile because it is also making a build before the tests)

{
	// Use IntelliSense to learn about possible attributes.
	// Hover to view descriptions of existing attributes.
	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
	"version": "0.2.0",
	"configurations": [
	{
		"command": "npm test",
		"name": "npm test",
		"request": "launch",
		"type": "node-terminal",
		"skipFiles": [
			"<node_internals>/**"
		],
	},
	],
}

@NovemLinguae NovemLinguae linked an issue Jun 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bypass redirects
2 participants