Add dark mode compatibility to Twinkle #2023
Open
+113
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Module: morebits
NovemLinguae
previously requested changes
Oct 17, 2024
|
P.S. If you make future pull requests, you should probably do it on a different branch in your repo than master. Can get buggy especially if you do multiple pull requests at the same time. |
siddharthvp
reviewed
Oct 19, 2024
| @@ -304,3 +349,39 @@ th.morebits-mbox-text, td.morebits-mbox-text { | |||
| padding: 0.25em 0.9em; | |||
| width: 100%; | |||
| } | |||
|
|
|||
| /* Twinkle config */ | |||
There was a problem hiding this comment.
Twinkle-specific styles should go to twinkle.css, not here.
| color: var(--color-subtle, #54595d); | ||
| } | ||
|
|
||
| /* Override select2 silliness */ |
There was a problem hiding this comment.
select2 dropdowns look broken:
| --morebits-color-info: #6BDB6B; | ||
| --morebits-color-warning: #FFC7B3; | ||
| --morebits-color-titlebar-links: #8BADDF; | ||
| --morebits-bgcolor-dialog: #17244A; |
There was a problem hiding this comment.
This is subjective, but I think the blue on black looks terrible. Might want to use a shade of grey instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested locally, it seems to work.