eslint: switch from custom rules to eslint-config-wikimedia #1976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/wikimedia/eslint-config-wikimedia
Why switch?
What this patch does
no-nested-ternary
no-restricted-syntax
for.done()
and.fail()
space-in-parens
,space-before-function-paren
,array-bracket-spacing
,computed-property-spacing
,object-curly-spacing
)max-len
)indent
because it would involve touching almost every line, messing up git blame (although I may autofix this in the future and set a .git-blame-ignore-revs to reduce git blame spam)wrap-iife
to reduce VS Code yellow underline spam (will autofix this in a future patch)The rules are in two groups, with an extra line break in the middle separating them.
Over time, rules will be fixed and removed from the config, and the code will be incrementally modernized, until it arrives at the Wikimedia standard.