welcome: Add {{welcome-suboptimal}} and {{welcome-anon-suboptimal}} #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Module: welcome
dependencies
NovemLinguae
requested changes
Sep 6, 2024
There was a problem hiding this comment.
The diff on this one is massive.
https://github.com/wikimedia-gadgets/twinkle/pull/1955/files
Perhaps it's because you're using the master branch of your fork for multiple PRs. Or perhaps it's because you ran a linter or your code editor ran a linter and it changed a ton of lines.
I'd recommend closing and resubmitting this PR, but make sure you don't use the master branch. Create a new branch. Each PR you create should get a new and unique branch in your fork :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1950.