Support batch requested moves #1888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: 
|
NovemLinguae
reviewed
Sep 6, 2024
| @@ -371,7 +371,7 @@ Morebits.quickForm.prototype.append = function QuickFormAppend(data) { | |||
| * There is some difference on how types handle the `label` attribute: | |||
| * - `div`, `select`, `field`, `checkbox`/`radio`, `input`, `textarea`, `header`, and `dyninput` can accept an array of items, | |||
| * and the label item(s) can be `Element`s. | |||
| * - `option`, `optgroup`, `_dyninput_element`, `submit`, and `button` accept only a single string. | |||
| * - `option`, `optgroup`, `_dyninput_cell`, `submit`, and `button` accept only a single string. | |||
There was a problem hiding this comment.
For my understanding, what does _dyninput_cell do and why did its name change?
| event: data.event | ||
| event: data.event, | ||
| inputs: data.inputs || [{ | ||
| // compatibility |
There was a problem hiding this comment.
For my understanding, what's going on with the compatibility sub-section here?
| @@ -800,6 +785,41 @@ Morebits.quickForm.element.prototype.compute = function QuickFormElementCompute( | |||
| removeButton.morebutton = data.morebutton; | |||
| } | |||
| break; | |||
| case '_dyninput_cell': // Private, similar to normal input | |||
There was a problem hiding this comment.
for my understanding, why did this case move down?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681