Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag: add {{No significant coverage (sports)}} and {{No significant coverage}} #1834

Merged
merged 15 commits into from
Sep 6, 2024

Conversation

earlt612
Copy link
Contributor

@earlt612 earlt612 commented Jul 25, 2023

Resolves #1817 and #2001

@Eejit43
Copy link

Eejit43 commented Mar 1, 2024

The template names have typos, they should be "significant" instead of "signifigant".

Additionally, more consistent descriptions would be:

does not cite any sources containing significant coverage
and
sports biography that does not cite any sources containing significant coverage

modules/friendlytag.js Outdated Show resolved Hide resolved
@earlt612
Copy link
Contributor Author

@NovemLinguae: Requested changes have been completed

@NovemLinguae
Copy link
Member

Thanks. I am finishing up a burst of work on https://github.com/wikimedia-gadgets/afc-helper. When I am done with that I will try to do a burst of work on Twinkle and catch up on all the PRs.

@earlt612
Copy link
Contributor Author

No problem. Take your time

@NovemLinguae
Copy link
Member

NovemLinguae commented Sep 4, 2024

{{No significant coverage}} is fine and can go in.

{{No significant coverage (sports)}} - we should wait and see how the TFD goes. even if the TFD passes, maybe we should decline to add that one. I might need to think about it.

@NovemLinguae NovemLinguae linked an issue Sep 4, 2024 that may be closed by this pull request
@NovemLinguae
Copy link
Member

The TFD is leaning keep. This PR has sat long enough. Let's approve it and get it in :)

@NovemLinguae NovemLinguae merged commit 3a9de06 into wikimedia-gadgets:master Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag: add {{No significant coverage}} tag: Add {{No significant coverage (sports)}}
3 participants