warn: allow user to preview/change edit summary before warning #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovemLinguae
requested changes
Aug 10, 2023
There was a problem hiding this comment.
A pretty complex first patch. Nice work.
Can we delete the <legend>Warning information</legend>? I don't think it makes much sense to have linked page outside of it, and edit summary, optional message, and preview inside of it.
I think we can also move "edit summary" to above "linked page". Visually I'd like linked page and optional message grouped, since those both get turned off sometimes. Would be weird to have edit summary in the middle of that.
siddharthvp
reviewed
Aug 12, 2023
| Twinkle.warn.callback.set_tentative_edit_summary = function twinkleWarnCallbackSetTentativeEditSummary(e) { | ||
| var selected_main_group = e.target.form.main_group.value; | ||
| var selected_template = e.target.form.sub_group.value; | ||
| var messageData = $(e.target.form.sub_group).find('option[value="' + $(e.target.form.sub_group).val() + '"]').data('messageData'); |
There was a problem hiding this comment.
There has to be a less error-prone (what if the value contains special chars?) and more elegant way to do this.
Maybe something like $(e.target.form.sub_group).find('option:selected') ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon opening the warning dialog, the user has the option to modify the edit summary that will eventually be used.
Currently, the edit summary (including any edits by the user) will be replaced entirely when a new warning is selected or when the linked page is changed. Not sure if this needs to be changed down the line to try to preserve the user's edits.
Resolves #1803