Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added media related and emoji redirect templates #1741

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Added media related and emoji redirect templates #1741

merged 4 commits into from
Jul 20, 2023

Conversation

Gonzom
Copy link
Contributor

@Gonzom Gonzom commented Mar 2, 2023

Added media redirect templates (band name, cover song, journal, lyric, meme, television program, upcoming film, work) and emoji redirect template.

@NovemLinguae
Copy link
Member

NovemLinguae commented Jul 20, 2023

Hey @Gonzom. Thanks for the patch. Tips for the future:

  1. Please test your patch. This one wasn't working. The front end was missing a check box, and the back end had no code to read the check box and transform the template wikicode (e.g. when you tick the flag box, it will write {{R from emoji}} instead of {{R from emoji|flag=yes}}). The instructions for testing are at https://github.com/wikimedia-gadgets/twinkle/blob/master/CONTRIBUTING.md#testing-your-code

  2. Please create a new branch in git when submitting pull requests. Using the master branch can lead to some nasty bugs, especially if you try to open 2 pull requests at the same time.

I'll try to finish this one up for you if I get time. Although feel free to work on it yourself if I don't get around to it.

@NovemLinguae
Copy link
Member

OK, in the interest of getting this merged, I'm going to remove the optional parameters from {{R from emoji}}. If you want to code it up, feel free to submit a follow up patch. The code wouldn't be too hard. It'd be something like...

			{
				tag: 'R from emoji',
				description: 'redirect from an emoji to an article describing the depicted concept or the emoji itself',
				subgroup: [
					{
						name: 'emojiName',
						type: 'input',
						label: 'Emoji name',
						tooltip: 'Enter the name of the emoji'
					}, {
						type: 'checkbox',
						list: [
							{
								name: 'emojiIsFlag',
								label: 'Flag',
								tooltip: 'Is the emoji a flag emoji?'
							}
						]
					}
				]
			},

and

image

@NovemLinguae NovemLinguae merged commit c305fce into wikimedia-gadgets:master Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants