Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Link Count in all namespaces #48

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

nardog
Copy link
Contributor

@nardog nardog commented Feb 22, 2024

Link Count is useful in all content namespaces, and it's misleading for the label to say "Transclusion count".

Copy link
Collaborator

@MusikAnimal MusikAnimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

it's misleading for the label to say "Transclusion count"

Indeed. This is because it originally linked to https://templatecount.toolforge.org/ which exclusively shows the transclusion count. "Link count" came around with a much better UI and additional data, so I just changed the link, but never updated the message.

To that end, given we have a very poor JS-based translation system (as opposed to using translatewiki), I wonder if we should keep the transclusion-count key and simply rename the message. That way, non-English users still see something that is at least vaguely correct, because I imagine translators will be slow to make updates.

I guess this is fine for now. I'll try to get MoreMenu hooked up to translatewiki soon so that we don't run into similar issues moving forward.

@MusikAnimal MusikAnimal merged commit 6dd9bc6 into wikimedia-gadgets:master Feb 24, 2024
1 check passed
@nardog
Copy link
Contributor Author

nardog commented Feb 24, 2024

I actually noticed this after seeing a request to update a translation. In the same vein as what I said there, I believe labels should be honest about what they're linking to.

(If you're so inclined, add "link-count": "被リンク数", to MediaWiki:Gadget-MoreMenu.messages.ja.js once this gets deployed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants