Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem version to 1.2.1 #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

masashimorita
Copy link
Contributor

Update gem version
@westonplatter

@masashimorita masashimorita marked this pull request as ready for review March 14, 2023 09:21
@masashimorita
Copy link
Contributor Author

@westonplatter
Would you please check this PR?

@westonplatter
Copy link
Owner

@masashimorita what changes would be included in this version bump?

@dvandersluis
Copy link

Will this be released anytime soon?

@kimegede
Copy link

I would like to see this PR merged as well 🥺 🙏

@westonplatter
Copy link
Owner

@masashimorita Thank you for pulling together the merged PRs - it makes a difference seeing a concrete list. Thanks.

I'm game to release a version bump.

Given the new method in #50, I'm think a minor release is more appropriate. I'm basing my logic from https://semver.org/#spec-item-7. Thoughts?

Given the this gem is older and updated less, I would rather side with caution and give the large user base ample chance to digest what's changing. I don't want to make a quick decision that negatively impacts downstream users.

@kimegede
Copy link

Think minor or patch is acceptable for these changes 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants