Skip to content

Commit

Permalink
fix(tests): tests/Makefile unnecessarily regenerates
Browse files Browse the repository at this point in the history
tests/ruleset.am should not depend on the modification dates of the
*.rules files in the directory. 'bmake' (NetBSD make; also available in
some Linux distros) can occasionally treat 'ruleset.am' as outdated and
unnecessarily regenerates it, causing a chain of regeneration of
Makefiles or even dependency tracking error.

(This might look like a bug in bmake's side, but we should remove false
dependencies in makefiles anyway. 'ruleset.am' only depends on the names
and existences of the *.rules files, not their contents or modification
dates.)
  • Loading branch information
Explorer09 committed May 13, 2024
1 parent 74a1321 commit b0d8bab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ RULESETS = \
$(srcdir)/yymorearraybol.rules \
$(srcdir)/yyunput.rules

$(srcdir)/ruleset.am: $(srcdir)/ruleset.sh $(RULESETS)
$(srcdir)/ruleset.am: $(srcdir)/ruleset.sh
( cd $(srcdir) && $(SHELL) ruleset.sh nr r c99 go >ruleset.am )

include $(srcdir)/ruleset.am
Expand Down

0 comments on commit b0d8bab

Please sign in to comment.