Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26 Complete full lines #39

Merged
merged 6 commits into from
Jul 7, 2014
Merged

26 Complete full lines #39

merged 6 commits into from
Jul 7, 2014

Conversation

wellle
Copy link
Owner

@wellle wellle commented Jul 1, 2014

Closes #38.

Towards #26.

@wellle wellle mentioned this pull request Jul 1, 2014
@justinmk
Copy link
Contributor

justinmk commented Jul 1, 2014

Nice cleanup! LGTM

let command .= ' ' . shellescape(base_pattern)
let command .= ' ' . shellescape(list_args)
let command .= ' ' . shellescape(a:capture_args)
echom command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove this.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@wellle
Copy link
Owner Author

wellle commented Jul 7, 2014

Ok I guess we can merge this now and iterate later. Currently the line completion is not available and the Unity line listing seems to make sense.

Thanks again!

wellle added a commit that referenced this pull request Jul 7, 2014
@wellle wellle merged commit f095f33 into master Jul 7, 2014
@wellle wellle deleted the 26-full-lines branch July 7, 2014 08:21
@wellle wellle mentioned this pull request Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants