Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON data source #94

Closed
wants to merge 8 commits into from
Closed

JSON data source #94

wants to merge 8 commits into from

Conversation

satelllte
Copy link
Contributor

@satelllte satelllte commented Aug 30, 2023

About

Moving data source to data.json file.

@webprofusion-chrisc if you want to have it split by groups, let me know, so I can submit it in another PR.

Checklist

@satelllte satelllte marked this pull request as ready for review August 30, 2023 19:40
@webprofusion-chrisc
Copy link
Contributor

That's great! Thanks, I wasn't expecting this either :) - yes we would need it split into at least one JSON file per type/schema (so a plugins.json and an apps.json etc) and I would prefer the json files to be in their own subfolder within the project structure so they don't sit directly next to any code. The subfolder could be something like /config, /json or a top level /data etc because ideally then if someone wants to refer to the file directly they just use a simple URL like https://openaudio.webprofusion.com/data/plugins.json

@Marat-Tanalin
Copy link
Collaborator

@webprofusion-chrisc

The subfolder could be something like /config, /json or a top level /data

data root folder looks like the most natural choice.

@satelllte
Copy link
Contributor Author

closing in favor of #96

@satelllte satelllte closed this Aug 31, 2023
@satelllte satelllte deleted the json branch August 31, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants