Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps bump #5034

Merged
merged 18 commits into from
Jan 23, 2024
Merged

Deps bump #5034

merged 18 commits into from
Jan 23, 2024

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

Bump all deps before release

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (26aae7e) 82.75% compared to head (3898849) 91.94%.

Files Patch % Lines
lib/Server.js 80.00% 3 Missing ⚠️
client-src/utils/createSocketURL.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5034      +/-   ##
==========================================
+ Coverage   82.75%   91.94%   +9.19%     
==========================================
  Files          15       15              
  Lines        1577     1577              
  Branches      600      600              
==========================================
+ Hits         1305     1450     +145     
+ Misses        228      118     -110     
+ Partials       44        9      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait
Copy link
Member Author

New version is much faster ⭐

@alexander-akait
Copy link
Member Author

@snitin315 Looks like we have some problems on macos for our overlay tests, can you try it locally? I think should be easy to fix

@snitin315
Copy link
Member

I'll check locally on MacOS

@snitin315
Copy link
Member

@alexander-akait It's working fine locally on MacOS, I think it's flaky on CI. I triggered a re-run and now it's green

Screenshot 2024-01-23 at 3 38 05 PM

@alexander-akait alexander-akait merged commit 48f56d5 into master Jan 23, 2024
40 of 41 checks passed
@alexander-akait alexander-akait deleted the deps-bump branch January 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants