feat: next #4655

snitin315 · 2022-11-26T01:18:16Z

For Bugs and Features; did you add new tests?

Motivation / Use-Case

We are preparing for the next major release.

TODO:

Breaking Changes

Additional Info

codecov · 2022-11-26T01:20:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (540c438) 90.38% compared to head (7a3eab9) 92.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
+ Coverage   90.38%   92.07%   +1.68%     
==========================================
  Files          16       15       -1     
  Lines        1706     1577     -129     
  Branches      649      600      -49     
==========================================
- Hits         1542     1452      -90     
+ Misses        150      116      -34     
+ Partials       14        9       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

snitin315 · 2023-01-21T09:40:07Z

@alexander-akait Should we remove the support of the compiler option as the first argument in this release?

webpack-dev-server/lib/Server.js

Lines 218 to 224 in ff4c194

    
           // TODO: remove this after plugin support is published 
        
           if (/** @type {Compiler | MultiCompiler} */ (options).hooks) { 
        
             util.deprecate( 
        
               () => {}, 
        
               "Using 'compiler' as the first argument is deprecated. Please use 'options' as the first argument and 'compiler' as the second argument.", 
        
               "DEP_WEBPACK_DEV_SERVER_CONSTRUCTOR" 
        
             )();

Also, I'm not sure what needs to be done in the following TODOs to resolve them:

webpack-dev-server/lib/Server.js

Line 446 in ff4c194

    
           // TODO improve for the next major version - we should store `web` and other targets in `compiler.options.environment`

webpack-dev-server/lib/Server.js

Line 490 in ff4c194

// TODO maybe empty client

webpack-dev-server/lib/Server.js

Line 532 in ff4c194

// TODO show warning about this

webpack-dev-server/lib/Server.js

Line 817 in ff4c194

// TODO: do merge in the next major release

webpack-dev-server/lib/Server.js

Line 829 in ff4c194

// TODO: do merge in the next major release

webpack-dev-server/lib/Server.js

Line 2054 in ff4c194

// TODO remove in the next major in favor `context` and `router` options

alexander-akait · 2023-03-14T18:01:17Z

@snitin315 Let's rebase and I think we need finish it this month 😄 What we need to finish?

snitin315 · 2023-03-16T01:15:12Z

@alexander-akait only this #4655 (comment)

alexander-akait · 2023-03-16T10:16:15Z

Should we remove the support of the compiler option as the first argument in this release?

Yeah, it will be pain, but we need to do it, our webpack-cli is ready for this?

// TODO improve for the next major version - we should store web and other targets in compiler.options.environment

We need to solve it on webpack side, because we don't have compiler.options.environment https://github.com/webpack/webpack/blob/main/lib/config/defaults.js#L928 and we can't know what env of developer, will be great to fix in on webpack side, just store options.environment in compiler.options.environment

// TODO maybe empty client
// TODO show warning about this

The first is a small bug, but I don't think somebody use it, the second just a warning improvement

// TODO: do merge in the next major release

Not sure what I want here 😃 Maybe we should merge default options with provided, so developer dont' need to seutp all of them, need investigate what is default and what is our to avoid massive regressions

// TODO remove in the next major in favor context and router options

It is very simple PR but and hard in the same time, http-proxy-middleware has this feature and you can achive it using router, but I am afraid we will break a lot, so let's generate a warning here, like "bypass is deprecated, please look at example of migration (link on examples/docs in http-proxy-middleware repo)"

linux-foundation-easycla · 2023-04-19T16:02:46Z

The committers listed above are authorized under a signed CLA.

✅ login: snitin315 / name: Nitin Kumar (7391e21, 50ea9a2, e26fc0b, e51810b, 397f621, efbd6e9, 654a77f, 5bb990e, 8ce29b8, f7f97b0, 36a9cf4, 9261305, b483b99, ca15bd0, db73a84, 724d07d, 2e4eaa7, b565b42, f145b8b, b525b7e, 0b9cad2, c2c3783, 15646a1, 3fd5202, ec14689, 42ec99f, cee9a91, 9c277f9, be53f43, 0e7f010, 3b7233b, fb0e709, bb7f8c6, 536bd38, 11ae42b, 92be098, dce8fc6, 0da7eb9, 3d518d7, b9c3c2f, 1d06427, 8742107, 4f5faa4, d537f40, 099076e, 203e7a7, 5ed2885, 1e62cba, 8e965ac, 33e1c76, 6855503, 370b9ef, 64d38d5, ea22b53, 1a32be7, 18ec451, fbe8f4d, cccad8c, 071e0ca, e98a017, 3032ee7, 5b0e727, 5a6a1f1, c40e7c2)
✅ login: malcolm-kee / name: Malcolm Kee (57b704f)
✅ login: cwj0417 / name: chen wen jun (7a3eab9)

snitin315 · 2023-04-22T03:17:33Z

/easycla

snitin315 · 2023-05-06T03:27:06Z

// TODO improve for the next major version - we should store web and other targets in compiler.options.environment

We need to solve it on webpack side, because we don't have compiler.options.environment https://github.com/webpack/webpack/blob/main/lib/config/defaults.js#L928 and we can't know what env of developer, will be great to fix in on webpack side, just store options.environment in compiler.options.environment

@alexander-akait You mean we should add a new option environment in webpack config and it should be union of target and output.environment?

snitin315 · 2023-05-06T03:33:53Z

// TODO maybe empty client

webpack-dev-server/lib/Server.js

Line 490 in ff4c194

// TODO maybe empty client

Do you mean if the user passed client: {}? Even then we normalize client options and it will be resolved to { webSocketURL: {}, overlay: true, reconnect: 10, logging: 'info' }

alexander-akait · 2023-05-06T20:53:40Z

Do you mean if the user passed client: {}?

Yeah, developer can use it, we just need to normalize to our default value

alexander-akait · 2023-05-06T20:56:38Z

@alexander-akait You mean we should add a new option environment in webpack config and it should be union of target and output.environment?

I think we need this https://github.com/webpack/webpack/blob/main/lib/config/defaults.js#L146 because we need to undestand what is enviroment, is it web or is it node is it something else

alexander-akait · 2023-05-07T12:35:38Z

@snitin315 Also, I think let's remove magicHtml option, it is broken for modules, don't see who used it, also it decrease perf, because we need to check it on every request

alexander-akait · 2023-05-09T06:44:01Z

@snitin315 Can you show me what is left, so I will plan our release and my work, thank you

snitin315 · 2023-05-09T09:38:09Z

@alexander-akait Following TODOs are pending, but we can postpone some.

webpack-dev-server/lib/Server.js

Line 457 in eb7f1f5

    
           // TODO improve for the next major version - we should store `web` and other targets in `compiler.options.environment`

webpack-dev-server/lib/Server.js

Line 501 in eb7f1f5

// TODO maybe empty client

webpack-dev-server/lib/Server.js

Line 797 in eb7f1f5

    
           // TODO: we respect these options for all watch options and allow developers to pass them to chokidar, but chokidar doesn't have these options maybe we need revisit that in future

webpack-dev-server/lib/Server.js

Line 834 in eb7f1f5

// TODO: do merge in the next major release

Other than this I will start writing a migration guide for v5 and update docs on webpack.js.org too.

alexander-akait · 2023-05-11T08:42:44Z

@snitin315 Yeah, let's start to write migration guide, because they are just fixes 👍

alexander-akait · 2023-05-21T21:18:07Z

@snitin315 Sorry for pings 😄 Any progress?

snitin315 · 2023-05-22T02:22:06Z

@alexander-akait Hi, I was away from home last week, I'll send PR for the migration guide tonight. In the meantime, let's not merge more deps PR in the master.

alexander-akait · 2023-05-22T17:00:32Z

@snitin315 Thank you, yeah, agree 👍 (hope there are no critical bugs while we are preparing release 😄 )

alexander-akait · 2023-05-28T00:30:41Z

Okay, I looked deeply on our TODOs, we need to finish

TODO: do merge in the next major release
TODO improve for the next major version - we should store web and other targets in compiler.options.environment

I will send PR in webpack for the latest, for the first we should need merge options with our defaults values (now we are override them)

BREAKING CHANGE: minimum supported Nodejs version is 14.15.0

…4923)

* chore: update core dependencies * chore: update webpack merge * chore: update snapshots

alexander-akait · 2024-01-13T12:22:39Z

@snitin315 Let's update webpack-dev-middleware to the latest version here too

alexander-akait · 2024-01-16T14:18:48Z

@snitin315 Did we resolve all TODOs here? Because after updating webpack-dev-middleware I want to merge it to the master/main

snitin315 · 2024-01-16T14:24:10Z

@alexander-akait Following TODOs are pending, maybe we can postpone these. I'll update webpack-dev-middleware.

webpack-dev-server/lib/Server.js

Line 471 in 5a6a1f1

    
           // TODO improve for the next major version - we should store `web` and other targets in `compiler.options.environment`

webpack-dev-server/lib/Server.js

Line 515 in 5a6a1f1

// TODO maybe empty client

webpack-dev-server/lib/Server.js

Line 471 in 5a6a1f1

    
           // TODO improve for the next major version - we should store `web` and other targets in `compiler.options.environment`

alexander-akait · 2024-01-16T14:45:34Z

Looks, fine, we can improve them later, because it is not a blocker

…new proxy config. (#5001)

alexander-akait · 2024-01-22T12:40:22Z

Let's merge

alexander-akait · 2024-01-22T12:40:49Z

@snitin315 Will you write the migration guide? Thank you

snitin315 force-pushed the next branch from c4f0f87 to 5a71fb8 Compare November 26, 2022 20:05

snitin315 force-pushed the next branch from 1c610c1 to f3cda1e Compare March 16, 2023 01:27

snitin315 force-pushed the next branch from f3cda1e to 6a8a8fc Compare April 7, 2023 02:15

snitin315 force-pushed the next branch from 703e0f9 to de2f7f5 Compare May 6, 2023 03:06

snitin315 force-pushed the next branch from be0f6ed to 1dad42d Compare May 25, 2023 05:24

snitin315 added 6 commits January 13, 2024 11:42

build!: minimum supported Nodejs version is 14.15.0 (#4645)

7391e21

BREAKING CHANGE: minimum supported Nodejs version is 14.15.0

refactor!: minimum supported webpack version is v5.0.0 (#4656)

50ea9a2

refactor!: remove deprecated listen and close methods (#4659)

e26fc0b

refactor!: remove the https and the http2 option (#4661)

e51810b

chore: remove webpack 4 workarounds from tests (#4667)

397f621

refactor!: remove the deprecated option server.options.cacert (#4668)

efbd6e9

snitin315 added 12 commits January 13, 2024 11:42

test: refactor server & client transport tests to cleanup properly (#…

33e1c76

…4923)

test: refactor multi-compiler tests to cleanup properly (#4924)

6855503

test: refactor webSocketServerURL tests to cleanup properly (#4925)

370b9ef

test: fix flaky overlay E2E tests (#4929)

64d38d5

chore: update core dependencies (#4928)

ea22b53

* chore: update core dependencies * chore: update webpack merge * chore: update snapshots

refactor: remove file-loader and url-loader deps (#4951)

1a32be7

chore: pin webpack version to v5.87.0 (#4965)

18ec451

refactor: remove webpack v4 code (#4967)

fbe8f4d

test: add cases for staticOptions normalization (#4969)

cccad8c

ci: update commitlint-github-action to v5 (#4971)

071e0ca

docs: update CLI options in README (#4970)

e98a017

feat: improve static.serveIndex defaults (#4968)

3032ee7

snitin315 force-pushed the next branch from 1750353 to 3032ee7 Compare January 13, 2024 06:12

ci: fix npm security audit (#5028)

5b0e727

build!: minimum supported Node.js version is 18.12.0 (#5029)

5a6a1f1

snitin315 and others added 2 commits January 19, 2024 14:17

chore: update webpack-dev-middleware and other deps (#5032)

c40e7c2

fix: clean 'close' event listeners on socket server after generating …

7a3eab9

…new proxy config. (#5001)

snitin315 marked this pull request as ready for review January 21, 2024 04:36

snitin315 requested review from alexander-akait, hiroppy and anshumanv as code owners January 21, 2024 04:36

alexander-akait approved these changes Jan 22, 2024

View reviewed changes

alexander-akait merged commit 26aae7e into master Jan 22, 2024
65 of 78 checks passed

alexander-akait deleted the next branch January 22, 2024 12:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: next #4655

feat: next #4655

snitin315 commented Nov 26, 2022 •

edited by alexander-akait

Loading

codecov bot commented Nov 26, 2022 •

edited

Loading

snitin315 commented Jan 21, 2023

alexander-akait commented Mar 14, 2023

snitin315 commented Mar 16, 2023

alexander-akait commented Mar 16, 2023

linux-foundation-easycla bot commented Apr 19, 2023 •

edited

Loading

snitin315 commented Apr 22, 2023

snitin315 commented May 6, 2023

snitin315 commented May 6, 2023

alexander-akait commented May 6, 2023

alexander-akait commented May 6, 2023

alexander-akait commented May 7, 2023

alexander-akait commented May 9, 2023

snitin315 commented May 9, 2023

alexander-akait commented May 11, 2023

alexander-akait commented May 21, 2023

snitin315 commented May 22, 2023

alexander-akait commented May 22, 2023 •

edited

Loading

alexander-akait commented May 28, 2023 •

edited

Loading

alexander-akait commented Jan 13, 2024

alexander-akait commented Jan 16, 2024

snitin315 commented Jan 16, 2024 •

edited

Loading

alexander-akait commented Jan 16, 2024

alexander-akait commented Jan 22, 2024

alexander-akait commented Jan 22, 2024

feat: next #4655

feat: next #4655

Conversation

snitin315 commented Nov 26, 2022 • edited by alexander-akait Loading

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Nov 26, 2022 • edited Loading

Codecov Report

snitin315 commented Jan 21, 2023

alexander-akait commented Mar 14, 2023

snitin315 commented Mar 16, 2023

alexander-akait commented Mar 16, 2023

linux-foundation-easycla bot commented Apr 19, 2023 • edited Loading

snitin315 commented Apr 22, 2023

snitin315 commented May 6, 2023

snitin315 commented May 6, 2023

alexander-akait commented May 6, 2023

alexander-akait commented May 6, 2023

alexander-akait commented May 7, 2023

alexander-akait commented May 9, 2023

snitin315 commented May 9, 2023

alexander-akait commented May 11, 2023

alexander-akait commented May 21, 2023

snitin315 commented May 22, 2023

alexander-akait commented May 22, 2023 • edited Loading

alexander-akait commented May 28, 2023 • edited Loading

alexander-akait commented Jan 13, 2024

alexander-akait commented Jan 16, 2024

snitin315 commented Jan 16, 2024 • edited Loading

alexander-akait commented Jan 16, 2024

alexander-akait commented Jan 22, 2024

alexander-akait commented Jan 22, 2024

snitin315 commented Nov 26, 2022 •

edited by alexander-akait

Loading

codecov bot commented Nov 26, 2022 •

edited

Loading

linux-foundation-easycla bot commented Apr 19, 2023 •

edited

Loading

alexander-akait commented May 22, 2023 •

edited

Loading

alexander-akait commented May 28, 2023 •

edited

Loading

snitin315 commented Jan 16, 2024 •

edited

Loading