-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: next #4655
feat: next #4655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
+ Coverage 90.38% 92.07% +1.68%
==========================================
Files 16 15 -1
Lines 1706 1577 -129
Branches 649 600 -49
==========================================
- Hits 1542 1452 -90
+ Misses 150 116 -34
+ Partials 14 9 -5 ☔ View full report in Codecov by Sentry. |
@alexander-akait Should we remove the support of the webpack-dev-server/lib/Server.js Lines 218 to 224 in ff4c194
Also, I'm not sure what needs to be done in the following TODOs to resolve them: webpack-dev-server/lib/Server.js Line 446 in ff4c194
webpack-dev-server/lib/Server.js Line 490 in ff4c194
webpack-dev-server/lib/Server.js Line 532 in ff4c194
webpack-dev-server/lib/Server.js Line 817 in ff4c194
webpack-dev-server/lib/Server.js Line 829 in ff4c194
webpack-dev-server/lib/Server.js Line 2054 in ff4c194
|
@snitin315 Let's rebase and I think we need finish it this month 😄 What we need to finish? |
@alexander-akait only this #4655 (comment) |
Yeah, it will be pain, but we need to do it, our webpack-cli is ready for this?
We need to solve it on webpack side, because we don't have
The first is a small bug, but I don't think somebody use it, the second just a warning improvement
Not sure what I want here 😃 Maybe we should merge default options with provided, so developer dont' need to seutp all of them, need investigate what is default and what is our to avoid massive regressions
It is very simple PR but and hard in the same time, |
|
/easycla |
@alexander-akait You mean we should add a new option |
Do you mean if the user passed |
Yeah, developer can use it, we just need to normalize to our default value |
I think we need this https://github.com/webpack/webpack/blob/main/lib/config/defaults.js#L146 because we need to undestand what is enviroment, is it web or is it node is it something else |
@snitin315 Also, I think let's remove |
@snitin315 Can you show me what is left, so I will plan our release and my work, thank you |
@alexander-akait Following TODOs are pending, but we can postpone some. webpack-dev-server/lib/Server.js Line 457 in eb7f1f5
webpack-dev-server/lib/Server.js Line 501 in eb7f1f5
webpack-dev-server/lib/Server.js Line 797 in eb7f1f5
webpack-dev-server/lib/Server.js Line 834 in eb7f1f5
Other than this I will start writing a migration guide for v5 and update docs on webpack.js.org too. |
@snitin315 Yeah, let's start to write migration guide, because they are just fixes 👍 |
@snitin315 Sorry for pings 😄 Any progress? |
@alexander-akait Hi, I was away from home last week, I'll send PR for the migration guide tonight. In the meantime, let's not merge more deps PR in the master. |
@snitin315 Thank you, yeah, agree 👍 (hope there are no critical bugs while we are preparing release 😄 ) |
Okay, I looked deeply on our TODOs, we need to finish
I will send PR in webpack for the latest, for the first we should need merge options with our defaults values (now we are override them) |
BREAKING CHANGE: minimum supported Nodejs version is 14.15.0
* chore: update core dependencies * chore: update webpack merge * chore: update snapshots
@snitin315 Let's update webpack-dev-middleware to the latest version here too |
@snitin315 Did we resolve all TODOs here? Because after updating webpack-dev-middleware I want to merge it to the master/main |
@alexander-akait Following TODOs are pending, maybe we can postpone these. I'll update webpack-dev-middleware. webpack-dev-server/lib/Server.js Line 471 in 5a6a1f1
webpack-dev-server/lib/Server.js Line 515 in 5a6a1f1
webpack-dev-server/lib/Server.js Line 471 in 5a6a1f1
|
Looks, fine, we can improve them later, because it is not a blocker |
Let's merge |
@snitin315 Will you write the migration guide? Thank you |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
We are preparing for the next major release.
TODO:
magicHtml
optionBreaking Changes
Additional Info