Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Rename member output to outputs of MLLstmCellSupportLimits #757

Merged

Conversation

huningxin
Copy link
Contributor

@huningxin huningxin commented Sep 2, 2024

MLLstmCellSupportLimits.outputs reflects that lstmCell returns a sequence of operands.

Fix #755 (comment)


Preview | Diff

@huningxin
Copy link
Contributor Author

@shiyi9801 @philloooo PTAL, thanks!

`MLLstmCellSupportLimits.outputs` reflects that lstmCell returns a
sequence of operands.

Fix webmachinelearning#755 (comment)
@shiyi9801
Copy link
Contributor

LGTM!

@huningxin huningxin requested a review from fdwr September 2, 2024 07:07
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Collaborator

fdwr commented Sep 5, 2024

Although Phillis hasn't reviewed this, she did thumbs-up your comment on the matter, and you got 2 other reviews. So I will merge this.

@fdwr fdwr merged commit a2450a5 into webmachinelearning:main Sep 5, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Sep 5, 2024
…ts` (#757)

SHA: a2450a5
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants