-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: Define operand concept, simplify graph connection steps #591
Merged
fdwr
merged 12 commits into
webmachinelearning:main
from
inexorabletash:content-programming-model-operators
Mar 12, 2024
Merged
Content: Define operand concept, simplify graph connection steps #591
fdwr
merged 12 commits into
webmachinelearning:main
from
inexorabletash:content-programming-model-operators
Mar 12, 2024
Commits on Feb 28, 2024
-
Content: Define operand concept, simplify graph connection steps
As discussed in webmachinelearning#572: - Define an "operator" concept, with inputs, outputs, activations. - Defer "platform operator" and "platform operand" to build. - Standardize the graph connection steps across builder methods. - Simplify activation, input and constant steps. Not covered in this change: - Erroring if input's [[builder]] doesn't match `this` - Build algorithm - covered by webmachinelearning#448 and webmachinelearning#457 - gru() is missing steps to populate output. Added "Issue" note. - Introducing "Validate arguments" section for each method. - Introducing "Calculate output shape" section for each method. For webmachinelearning#549 and webmachinelearning#572.
Configuration menu - View commit details
-
Copy full SHA for 4f07efb - Browse repository at this point
Copy the full SHA 4f07efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfee70d - Browse repository at this point
Copy the full SHA dfee70dView commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18f2c84 - Browse repository at this point
Copy the full SHA 18f2c84View commit details -
lstm(): Fix output2 shape calculation
In tip-of-tree, the "desc" MLOperandDescriptor is populated, used, then modified and conditionally used again (if `returnSequence` is true) when creating "output2". This was broken in previous commits in this branch. Restore the intent, using a separate "desc2" MLOperandDescriptor only conditionally populated and then conditionally used.
Configuration menu - View commit details
-
Copy full SHA for d47d87c - Browse repository at this point
Copy the full SHA d47d87cView commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2c3f39 - Browse repository at this point
Copy the full SHA b2c3f39View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c794bdb - Browse repository at this point
Copy the full SHA c794bdbView commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 66d32bc - Browse repository at this point
Copy the full SHA 66d32bcView commit details
Commits on Mar 10, 2024
-
Co-authored-by: Ningxin Hu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aecbe70 - Browse repository at this point
Copy the full SHA aecbe70View commit details
Commits on Mar 11, 2024
-
Merge remote-tracking branch 'mine/content-programming-model-operator…
…s' into content-programming-model-operators
Configuration menu - View commit details
-
Copy full SHA for 9a8f84d - Browse repository at this point
Copy the full SHA 9a8f84dView commit details -
* Add other operand inputs * PreLU -> PReLU * Define split() output shapes calculations
Configuration menu - View commit details
-
Copy full SHA for 2246810 - Browse repository at this point
Copy the full SHA 2246810View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3cd48f - Browse repository at this point
Copy the full SHA a3cd48fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e818c3b - Browse repository at this point
Copy the full SHA e818c3bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.