Bug fix: Provide default for MLLayerNormalizationOptions axes in steps #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
changed the title
huningxin
approved these changes
Feb 2, 2024
inexorabletash
force-pushed
the
bugfix-layernormalization-axes
branch
from
917c369
to
77e0977
Compare
This adds an explicit algorithm step in layerNormalization() to provide a default described only in prose for the axes option. For webmachinelearning#211
inexorabletash
force-pushed
the
bugfix-layernormalization-axes
branch
from
77e0977
to
3a9acd5
Compare
|
@fdwr can you review (and merge if it looks good?) - thanks! |
fdwr
reviewed
Feb 9, 2024
fdwr
reviewed
Feb 10, 2024
Editing wording for 0D and 1D case.
|
Oh, we still ought to update the prose too, as it still says: "When this member is not present, it is assumed to be [1,2,3] that is..." I'll push another iteration and await re-review from Ningxin or Josh. |
|
(The build error is due to the lingering {{MLCommamdEncoder}} reference) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit algorithm step in layerNormalization() to provide a default described only in prose for the axes option.
For #211
Preview | Diff