Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the "Disable ADB secure" patch #26

Open
wants to merge 1 commit into
base: lineage-18.1
Choose a base branch
from

Conversation

ChrysoliteAzalea
Copy link
Contributor

@ChrysoliteAzalea ChrysoliteAzalea commented Sep 17, 2023

Hello everyone! I propose enabling the ro.adb.secure property.

Explanation:

Android Debug Bridge is a tools that allows remote communication with the Android system. On the Android system side, it's represented by the Android Debug Bridge Daemon, that runs as a special user (shell). ro.adb.secure is a property that allows ADBD to be managed by Android settings. If ro.adb.secure is set to 0, anyone that can connect to the Android system over network (including installed Android apps connecting to 127.0.0.1) can get access to the privileged shell with lots of irrevocable Android permissions, and remotely control the system through tools like scrcpy. If it's set to 1, all such interactions have to be authorized by the user -- it cannot be done over network.

Possible benefits:

  • ADB can be disabled in the settings (without re-enabling on container restart)
  • ADB connections have to be authorized by user
  • Such authorizations can be revoked

Possible problems:

I haven't found any.

@aleasto
Copy link
Member

aleasto commented Sep 17, 2023

Yea I'm not sure why we're carrying these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants