refactor: remove unnecessary to_string() #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murlakatamenka
commented
Mar 12, 2024
murlakatamenka
commented
|
Respect the honest work. All new patches need to be rebased onto |
|
@Shinyzenith yeah, no problems here. While at it, I'll push more commits to fix current |
murlakatamenka
force-pushed
the
aint-much
branch
from
c877a6a
to
682ba2d
Compare
|
Okay, it's a beefier PR now and ready to be reviewed. |
murlakatamenka
force-pushed
the
aint-much
branch
from
682ba2d
to
00f0c24
Compare
|
Hi the pr target needs to be changed to the above mentioned branch. |
|
Also I see you changed the previous commits of the branch which isn't ideal as their signature in the git object store will change. |
Typically `&Vec<T>` isn't something you want when you need a read-only view over a Vec, because it adds another level of indirection: Vec already stores a pointer to heap-allocated buffer internally. Using slices `&[T]` removes such unnecessary level of indirection and is considered a cleaner design. It is cache friendlier and can be better optimized by the compiler (not that it should matter in this case).
murlakatamenka
force-pushed
the
aint-much
branch
from
00f0c24
to
08dfe1d
Compare
|
Yeah, sorry for the fuss. The order is restored now, the target branch is that feature freeze one. |
|
Thank you for the patch! It's definitely honest work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.