Merge with upstream #132
Merged
Merge with upstream #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce#1744) `TypeInfo` currently tracks a type's size and whether it borrows anything. I originally had wondered whether it should also track sharedness, but I'm convincing myself this is unnecessary: - being shared or not shouldn't change the size - being shared or not doesn't change whether the type borrows This change removes the TODO.
If I understand `wast`'s `Expander` correctly (which I may not!), there is no need for it to know how to create type definitions for shared functions because there is no way to write WAT that would mark a function shared in an inline way. Since the only way to create a shared function is with an explicit type ID (e.g., `(func (type $ft))`), we can set `shared = false` when a `TypeDef` must be created.
This makes the `--help` and `-h` messages much more readable on terminals that don't happen to be hundreds of characters wide.
…ce#1747) This commit implements recognition of the `_initialize` function from WASIp1 in the componentization process of `wasm-tools component new`. This additionally corresponds to the same function in the proposed [BuildTargets.md](WebAssembly/component-model#378). This is implemented by having a small core wasm module which is just an import and a `start` section get instantiated at the end of a component to run `_initialize` before all other exports.
Routine update, nothing major
This shows up in all of the `--help` texts so figured that it might be good to expand its documentation a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.