fix: Jogging store is now disposed on motionGroupId change

wandelbotsgmbh · Sep 23, 2024 · fc82d24 · fc82d24
1 parent 39d5e72
commit fc82d24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/components/jogging/JoggingPanel.tsx b/src/components/jogging/JoggingPanel.tsx
@@ -1,4 +1,4 @@
-import { Paper, Stack, Tab, Tabs, useTheme } from "@mui/material"
+import { Stack, Tab, Tabs } from "@mui/material"
 import { NovaClient } from "@wandelbots/wandelbots-js"
 import { isString } from "lodash-es"
 import { runInAction } from "mobx"
@@ -29,8 +29,6 @@ export type JoggingPanelProps = {
  */
 export const JoggingPanel = externalizeComponent(
   observer((props: JoggingPanelProps) => {
-    const theme = useTheme()
-
     const nova = isString(props.nova)
       ? new NovaClient({ instanceUrl: props.nova })
       : props.nova
@@ -65,7 +63,7 @@ export const JoggingPanel = externalizeComponent(
       return () => {
         state.joggingStore?.dispose()
       }
-    }, [props.nova])
+    }, [props.nova, props.motionGroupId])
 
     useEffect(() => {
       const store = state.joggingStore

diff --git a/src/components/jogging/JoggingStore.tsx → src/components/jogging/JoggingStore.ts b/src/components/jogging/JoggingStore.tsx → src/components/jogging/JoggingStore.ts