Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/v1.3: Refactor for efficiency and speed #64

Closed
wants to merge 47 commits into from
Closed

Feat/v1.3: Refactor for efficiency and speed #64

wants to merge 47 commits into from

Conversation

parambharat
Copy link
Contributor

@parambharat parambharat commented Feb 16, 2024 •
edited
Loading

This PR includes the following changes to improve the efficiency and speed of wandbot

  • Replaces llama-index with LECL and makes LLM calls parallel
  • Improves parsing of documents in the ingestion
  • Replaces FAISS with ChromaDB
  • Improves the query enhancer to be a single LLM call
  • Splits the RAG pipeline into query enhancement, retrieval, and response synthesis modules
  • Adds parent document retrieval in the retrieval module
  • Adds sub-query answering in the response synthesis
  • Splits the API into routers for retrieval, database and chat - @ Breaking change for API definitions

TODO: Need to change the eval modules to use LECL from llama-index - @ayulockin

parambharat and others added 30 commits February 1, 2024 09:08
@parambharat
feat: use new openai models in chat and query enhancer
a3867a5
@parambharat
feat: use new models and embeddings model
7d6a187
@parambharat
chore: run linting and formatting changes
50aadb5
@parambharat
Merge branch 'feat/v1.1' into feat/v1.2
0e231b9
@parambharat
chore: add simple multi-index query engine with router
c027dde
@parambharat
refactor: move retriever to separate module.
ac58107
@parambharat
refactor: split out routers in the api
aa0427a
@parambharat
feat: add retriever routing and params
be5b8c2
@parambharat
feat: add routes to api client and update operation ids in openapi spec
aced990
@parambharat
feat: add you retriever separately in the end
477d83b
@parambharat
feat: switch to chromadb from faiss for speed
3e246eb
@parambharat
refactor: complete project overhaul to improve efficiency
c868d67
@parambharat
refactor: formatting and linting
e933232
@parambharat
stash: stash changes in handlers
281bec7
@parambharat
chore: switch add local changes on swordfish
0cc6bda
@parambharat
Merge branch 'feat/v1.3' of github.com:wandb/wandbot into feat/v1.3
63b3e77 
# Conflicts:
#	pyproject.toml
#	src/wandbot/api/app.py
#	src/wandbot/api/routers/retrieve.py
#	src/wandbot/chat/chat.py
#	src/wandbot/ingestion/__main__.py
#	src/wandbot/ingestion/prepare_data.py
#	src/wandbot/ingestion/vectorstores.py
#	src/wandbot/retriever/base.py
#	src/wandbot/retriever/external.py
#	src/wandbot/retriever/fusion.py
#	src/wandbot/retriever/postprocessors.py
@parambharat
chore: run formatters on updated code
9533214
@parambharat
stash: stash changes in handlers
dc89d3d
@parambharat
chore: stash response synthesis changes
d655cac
@parambharat
Merge branch 'feat/v1.3' of github.com:wandb/wandbot into feat/v1.3
cd3fee0
@parambharat
feat: add new response synthesis module and parsers
0ca26c0
@parambharat
Merge branch 'feat/v1.3' of github.com:wandb/wandbot into feat/v1.3
4d4a739
@parambharat
chore: run formatters and cleanup
3dfb0bd
@parambharat
feat: add parent document retriever to the rag pipeline
53147bd
@parambharat
chore: run formatters and linters
da57bb0
@parambharat
feat: add safesearch are improve fusion reranking.
65bc123
@parambharat
chore: run linters and formatters
4dff405
@parambharat
feat: add new rag pipeline into chat interface
aac8c3d
@parambharat
feat: fix chat endpoint with api
a4d5a25
@parambharat
refactor: change up the RAG pipeline with descriptors
e12d163
morganmcg1
morganmcg1 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we should run evals on this before releasing it, given there are so maybe changes we should be fully aware of the impact of all these updates

src/wandbot/ingestion/config.py Outdated Show resolved Hide resolved
src/wandbot/ingestion/prepare_data.py Show resolved Hide resolved
src/wandbot/ingestion/prepare_data.py Show resolved Hide resolved
src/wandbot/ingestion/prepare_data.py Outdated Show resolved Hide resolved
src/wandbot/ingestion/prepare_data.py Show resolved Hide resolved
src/wandbot/rag/query_handler.py Show resolved Hide resolved
src/wandbot/rag/response_synthesis.py Outdated Show resolved Hide resolved
src/wandbot/rag/utils.py Outdated Show resolved Hide resolved
src/wandbot/rag/query_handler.py Outdated Show resolved Hide resolved
src/wandbot/rag/query_handler.py Show resolved Hide resolved
@morganmcg1
Copy link
Member

Oh also, can you add a Table in the README towards the top of with the history of the Answer Correctness score as we've moved through each release please

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] None 0 57.1 kB Zac-HD, adriangb
pypi/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +4 851 kB Andrew.Svetlov, hellysmile
pypi/[email protected] Transitive: shell +2 109 kB gxg
pypi/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +15454 344 GB victorm
pypi/[email protected] environment Transitive: filesystem +6 752 kB blink1073, jupyter-release-bot, zsailer
pypi/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +15454 344 GB krassowski
pypi/[email protected] environment, eval, filesystem, network, shell Transitive: unsafe +17307 359 GB hwchase17
pypi/[email protected] environment 0 49.3 kB blink1073, datalayer, jtp, ...2 more
pypi/[email protected] environment, filesystem 0 38.9 kB ickc, jgm
pypi/[email protected] environment Transitive: eval, filesystem, shell, unsafe +4 10.7 MB samuelcolvin
pypi/[email protected] environment, filesystem, unsafe Transitive: eval, network, shell +15454 344 GB TutteInstitute, lmcinnes
pypi/[email protected] environment 0 21.8 kB naimetti
pypi/[email protected] environment, filesystem, unsafe 0 5.98 MB Julian
pypi/[email protected] environment, filesystem, network Transitive: eval, shell, unsafe +14 280 MB arsenetar, hsoft
pypi/[email protected] None 0 944 kB ashvardanian
pypi/[email protected] environment, eval, filesystem, network 0 122 kB blink1073, darian, jasongrout, ...2 more
pypi/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +15475 344 GB plinss

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

@ayulockin ayulockin mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganmcg1 morganmcg1 morganmcg1 approved these changes

@ayulockin ayulockin Awaiting requested review from ayulockin

@ash0ts ash0ts Awaiting requested review from ash0ts

@ArtsiomWB ArtsiomWB Awaiting requested review from ArtsiomWB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parambharat @morganmcg1 @ayulockin