feat: Multilingual Support and Code Quality Enhancements for v1 Release #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parambharat
commented
Nov 23, 2023
src/wandbot/apps/discord/config.py
Outdated
|
|
||
| EN_INTRO_MESSAGE = ( | ||
| "🤖 Hi {mention}: \n\n" | ||
| f"Please note that **wandbot is currently in alpha testing** and will experience frequent updates.\n\n" |
There was a problem hiding this comment.
Get rid of the alpha testing bit
parambharat
commented
Nov 23, 2023
src/wandbot/chat/chat.py
Outdated
| LanguageFilterPostprocessor(languages=[language, "python"]), | ||
| CohereRerank(top_n=5, model="rerank-multilingual-v2.0") | ||
| if language == "ja" | ||
| else CohereRerank(top_n=5, model="rerank-english-v2.0"), |
There was a problem hiding this comment.
reverse the condition and make language en
parambharat
commented
Nov 23, 2023
src/wandbot/evaluation/eval.py
Outdated
There was a problem hiding this comment.
add a readme and link to ayush's report.
There was a problem hiding this comment.
@ayulockin Please take a look here at the README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces key enhancements and fixes to wandbot, focusing on multilingual capabilities and code quality improvements.
Highlights
Multilingual Features: Added support for English and Japanese in chat bots; included language in database schema and routing.
Code Quality: Fixed issues related to timestamps, linting, and type annotations. Converted Slack app to async and improved docstrings and type annotations.
Configuration Updates: Resolved naming conflicts in configurations and updated environmental requirements.
Documentation: Updated README with new tokens and run commands.
Impact
These changes significantly enhance the bot's language handling capabilities and improve overall code maintainability and performance.