fix: Azure storage and Vault simplified #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyblasczyk
commented
Aug 2, 2024
Comment on lines
-133
to
-146
| locals { | ||
| container_name = try(module.storage[0].container.name, "") | ||
| account_name = try(module.storage[0].account.name, "") | ||
| access_key = try(module.storage[0].account.primary_access_key, "") | ||
| queue_name = try(module.storage[0].queue.name, "") | ||
| blob_container = var.external_bucket == null ? coalesce(var.blob_container, local.container_name) : "" | ||
| storage_account = var.external_bucket == null ? coalesce(var.storage_account, local.account_name) : "" | ||
| storage_key = var.external_bucket == null ? coalesce(var.storage_key, local.access_key) : "" | ||
| bucket = "az://${local.storage_account}/${local.blob_container}" | ||
| queue = (var.use_internal_queue || var.blob_container == "" || var.external_bucket == null) ? "internal://" : "az://${local.account_name}/${local.queue_name}" | ||
|
|
||
| redis_connection_string = "redis://:${module.redis.instance.primary_access_key}@${module.redis.instance.hostname}:${module.redis.instance.port}" | ||
| } | ||
|
|
There was a problem hiding this comment.
@jsbroks I am so glad to get rid of this.
|
This needs to be released before we can merge and roll out to QA |
jsbroks
approved these changes
Aug 2, 2024
zacharyblasczyk
changed the title
|
We have opted to hold off on releasing the ability to decouple the object store from the k8s cluster creation for now. |
zacharyblasczyk
changed the title
danielpanzella
approved these changes
Aug 5, 2024
jsbroks
pushed a commit
that referenced
this pull request
Aug 5, 2024
### [2.13.1](v2.13.0...v2.13.1) (2024-08-05) ### Bug Fixes * Azure storage and Vault simplified ([#89](#89)) ([4832d24](4832d24))
|
This PR is included in version 2.13.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.