Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional path var for instance level bucket path #84

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

levinandrew
Copy link
Contributor

@levinandrew levinandrew commented Jul 12, 2024

Below the TF plan are the updated env vars

TF plan:

Terraform will perform the following actions:

  # module.wandb.module.app_aks.azurerm_kubernetes_cluster.default will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "default" {
...

      ~ default_node_pool {
            name                         = "default"
            tags                         = {}
            # (24 unchanged attributes hidden)

          - upgrade_settings {
              - drain_timeout_in_minutes      = 0 -> null
              - max_surge                     = "10%" -> null
              - node_soak_duration_in_minutes = 0 -> null
            }
        }

        # (6 unchanged blocks hidden)
    }

  # module.wandb.module.wandb.helm_release.wandb will be updated in-place
  ~ resource "helm_release" "wandb" {
        id                         = "wandb-cr"
      ~ metadata                   = [
          - {
              - app_version    = "1.0.0"
              - chart          = "wandb-cr"
              - first_deployed = 1724465197
              - last_deployed  = 1724465197
              - name           = "wandb-cr"
              - namespace      = "default"
              - notes          = ""
              - revision       = 1
              - values         = jsonencode(
                    {
                      - name = "wandb"
                      - spec = <<-EOT
                            "values":
                              "app":
...
                                "bucket":
                                  "accessKey": "<redacted>"
                                  "name": "levinaztwostorage"
                                  "path": "wandb"
                                  "provider": "az"
                                "cloudProvider": "azure"
  ...
                        EOT
                    }
                )
              - version        = "0.1.0"
            },
        ] -> (known after apply)
        name                       = "wandb-cr"
        # (26 unchanged attributes hidden)

...

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Updated env vars:

wandb@wandb-app-6cc8d6b764-p55qm:~$ env | grep -i nested
BUCKET=az://levinaztwostorage/wandb/nested/path
    "store": "az://levinaztwostorage/wandb/nested/path",
OVERFLOW_BUCKET_ADDR=az://levinaztwostorage/wandb/nested/path
GORILLA_FILE_STORE=az://levinaztwostorage/wandb/nested/path
GORILLA_STORAGE_BUCKET=az://levinaztwostorage/wandb/nested/path

@levinandrew levinandrew marked this pull request as draft July 12, 2024 21:53
@levinandrew levinandrew changed the title feat: enable instance level subpath feat: Add optional path var for instance level bucket path Jul 31, 2024
@levinandrew levinandrew marked this pull request as ready for review August 24, 2024 02:27
@levinandrew levinandrew merged commit 2f430f2 into main Aug 26, 2024
5 checks passed
jsbroks pushed a commit that referenced this pull request Aug 26, 2024
## [2.14.0](v2.13.2...v2.14.0) (2024-08-26)

### Features

* Add optional path var for instance level bucket path  ([#84](#84)) ([2f430f2](2f430f2))
@jsbroks
Copy link
Member

jsbroks commented Aug 26, 2024

This PR is included in version 2.14.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants