Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make default node pool zone configurable #75

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: Make default node pool zone configurable #75

merged 2 commits into from
Jun 20, 2024

Conversation

flamarion
Copy link
Contributor

fix: Make default node pool zone configurable

This may help to workaround situations like this

Error: creating Kubernetes Cluster (Subscription: "c213eb8e-d0e7-4bbb-985a-2f8deac5c1c5" Resource Group Name: "wandb-hitachi" Kubernetes Cluster Name: "wandb-hitachi-cluster"): managedclusters.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="BadRequest" Message="The VM size of Standard_D4s_v3 is only allowed in zones [3 1] in your subscription in location 'japaneast'. "
with module.wandb.module.app_aks.azurerm_kubernetes_cluster.default
on .terraform/modules/wandb/modules/app_aks/main.tf line 1, in resource "azurerm_kubernetes_cluster" "default":
resource "azurerm_kubernetes_cluster" "default" {

@flamarion flamarion requested review from jsbroks and danielpanzella and removed request for jsbroks June 20, 2024 10:30
@flamarion flamarion merged commit cfa5a89 into main Jun 20, 2024
jsbroks pushed a commit that referenced this pull request Jun 20, 2024
@semantic-release-bot
chore(release): version 2.6.1 [skip ci]
5f80c96 
### [2.6.1](v2.6.0...v2.6.1) (2024-06-20)

### Bug Fixes

* Make default node pool zone configurable ([#75](#75)) ([cfa5a89](cfa5a89))
@jsbroks
Copy link
Member

jsbroks commented Jun 20, 2024

This PR is included in version 2.6.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpanzella danielpanzella danielpanzella approved these changes

@jsbroks jsbroks Awaiting requested review from jsbroks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flamarion @jsbroks @danielpanzella