Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support external primary bucket using uri #99

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Support external primary bucket using uri #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/public-dns-external/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ module "wandb_infra" {

bucket_name = var.bucket_name
bucket_kms_key_arn = var.bucket_kms_key_arn

use_internal_queue = true
}

Expand All @@ -61,10 +62,10 @@ module "wandb_app" {
license = var.wandb_license

host = module.wandb_infra.url
bucket = "s3://${module.wandb_infra.bucket_name}"
bucket_aws_region = module.wandb_infra.bucket_region
bucket = var.external_bucket != "" ? var.external_bucket : "s3://${module.wandb_infra.bucket_name}"
bucket_aws_region = var.external_bucket_region != "" ? var.external_bucket_region : module.wandb_infra.bucket_region
bucket_queue = "internal://"
bucket_kms_key_arn = module.wandb_infra.kms_key_arn
bucket_kms_key_arn = var.external_bucket != "" ? "" : module.wandb_infra.kms_key_arn
database_connection_string = "mysql://${module.wandb_infra.database_connection_string}"

wandb_image = var.wandb_image
Expand Down
13 changes: 13 additions & 0 deletions examples/public-dns-external/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,16 @@ variable "bucket_kms_key_arn" {
description = "The Amazon Resource Name of the KMS key with which S3 storage bucket objects will be encrypted."
default = ""
}

variable "external_bucket" {
description = "String to configure a non AWS bucket (s3://user:pass@bucket)"
type = string
default = ""
}

variable "external_bucket_region" {
description = "When using external bucket the Region is mandatory"
type = string
default = ""
}