Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cohere api #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sanal-cohere
Copy link

Fix the use of Cohere API by using the ChatCohere class of langchain-cohere

@nejumi
Copy link
Collaborator

nejumi commented Sep 20, 2024

Thank you very much for the PR. I'll conduct test on it. Once confirming it's OK, it will be merged.

@nejumi nejumi self-requested a review September 20, 2024 05:56
@sanal-cohere
Copy link
Author

Sounds good, thank you! Let me know if you run into any issues.

@nejumi
Copy link
Collaborator

nejumi commented Sep 30, 2024

@sanal-cohere Sorry for having you wait so long. I reviewed your PR and found that some additional correction is needed as MT-Bench part uses separated engine (This is our fault. Sorry for our messy codebase). I will send you a PR. After your review and merging my PR, I will merge your PR.

By the way, the API version of Command R+ performed much better than the open weight version in toxicity, though it does roughly the same in other categories. Does it equip guardrails functionality which open weight one does not have? This is interesting.
https://api.wandb.ai/links/wandb-japan/quoisa1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants