Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better warnings and default for optuna scheduler #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Better warnings and default for optuna scheduler #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f56caab
chore: add better handlign for misconfigured metrics
gtarpenning Aug 25, 2023
5f00f7b
don't default to 1
gtarpenning Aug 25, 2023
6080b4a
mint
gtarpenning Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions jobs/sweep_schedulers/optuna_scheduler/optuna_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from wandb.apis.public import QueuedRun, Run
from wandb.sdk.artifacts.artifact import Artifact
from wandb.sdk.launch.sweeps import SchedulerError
from wandb.sdk.launch.sweeps.scheduler import RunState, Scheduler, SweepRun
from wandb.sdk.launch.sweeps.scheduler import Scheduler, SweepRun

logger = logging.getLogger(__name__)
optuna.logging.set_verbosity(optuna.logging.WARNING)
Expand Down Expand Up @@ -60,7 +60,7 @@ def setup_scheduler(scheduler: Scheduler, **kwargs):
parser = argparse.ArgumentParser()
parser.add_argument("--project", type=str, default=kwargs.get("project"))
parser.add_argument("--entity", type=str, default=kwargs.get("entity"))
parser.add_argument("--num_workers", type=int, default=1)
parser.add_argument("--num_workers", type=int, default=None)
parser.add_argument("--name", type=str, default=f"job-{scheduler.__name__}")
cli_args = parser.parse_args()

Expand Down Expand Up @@ -574,11 +574,8 @@ def _poll_run(self, orun: OptunaRun) -> bool:

# run is complete
prev_metrics = orun.trial._cached_frozen_trial.intermediate_values
if (
self._runs[orun.sweep_run.id].state == RunState.FINISHED
and len(prev_metrics) == 0
and not self.is_multi_objective
):
# prev_metrics is always 0 for multi-objective runs
if len(prev_metrics) == 0 and not self.is_multi_objective:
# run finished correctly, but never logged a metric
wandb.termwarn(
f"{LOG_PREFIX}Run ({orun.sweep_run.id}) never logged metric: "
Expand All @@ -600,6 +597,13 @@ def _poll_run(self, orun: OptunaRun) -> bool:
return True

if self.is_multi_objective:
if len(metrics) == 0:
wandb.termerror(
f"{LOG_PREFIX}Run ({orun.sweep_run.id}) never logged metrics: "
+ f"'{self._metric_defs}'. Check your sweep "
+ "config and training script."
)
metrics = [[float("inf") if m.direction == optuna.study.StudyDirection.MINIMIZE else float("-inf") for m in self._metric_defs]]
last_value = tuple(metrics[-1])
else:
last_value = prev_metrics[orun.num_metrics - 1]
Expand Down