fix(web-chat): peer connected counter #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weboko
approved these changes
Sep 4, 2023
danisharora099
commented
Sep 5, 2023
| storePeers: peers | ||
| .filter((p) => p.protocols.includes(waku.StoreCodec)) | ||
| .map((p) => p.id), | ||
| //TODO: use from import |
There was a problem hiding this comment.
to be addressed with waku-org/js-waku#1532
fryorcraken
reviewed
Sep 13, 2023
| //TODO: use from import | ||
| filterPeers: peers | ||
| .filter((p) => | ||
| p.protocols.includes("/vac/waku/filter-subscribe/2.0.0-beta1") |
There was a problem hiding this comment.
why not using waku.filter.getPeers ? @danisharora099
There was a problem hiding this comment.
@fryorcraken
do you mean peers? it returns the peers that exist in the peer store for that protocol, and not the peers necessarily we're connected to at the time
There was a problem hiding this comment.
we could possible have a method on the BaseProtocol to fetch connected peers for that protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the peers connected counter mismatch identified in #264
protocol.peers()which returns peers in the peer storepeer:disconnecthandler to remove disconnected peersNotes