Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message for required flags #1061

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix message for required flags #1061

merged 1 commit into from
Jul 10, 2024

Conversation

gandarez
Copy link
Member

This PR fix message for required flags and also reorganize some constants.

@gandarez gandarez self-assigned this Jul 10, 2024
@gandarez gandarez enabled auto-merge July 10, 2024 13:31
cmd/logfile/logfile.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (8d8ecab) to head (e384f6d).

@@             Coverage Diff             @@
##           develop    #1061      +/-   ##
===========================================
- Coverage    62.70%   62.69%   -0.01%     
===========================================
  Files          382      382              
  Lines        16403    16404       +1     
===========================================
  Hits         10285    10285              
- Misses        5556     5557       +1     
  Partials       562      562              
Flag Coverage Δ
unittests 62.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/ini/ini.go 61.31% <ø> (ø)
pkg/offline/legacy.go 50.00% <ø> (ø)
cmd/logfile/logfile.go 83.33% <0.00%> (ø)
pkg/offline/offline.go 56.41% <0.00%> (ø)
cmd/run.go 43.11% <0.00%> (-0.16%) ⬇️

@gandarez gandarez merged commit b8816ca into develop Jul 10, 2024
11 of 13 checks passed
@gandarez gandarez deleted the bugfix/flags branch July 10, 2024 13:46
@alanhamlett alanhamlett mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants