Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_process_optimizes_image #152

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

Stormheg
Copy link
Member

@Stormheg Stormheg commented Sep 5, 2024

On my machine, one optimized version is 56kb smaller which surpasses the allowed tolerance but not in a negative way.

This PR addresses that issue and uses assertAlmostEqual because it's delta parameter is clearer than a factor.

Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complaints from me

On my machine, one optimized version is 56kb smaller which surpasses the
allowed tolerance but not in a negative way.

use `assertAlmostEqual` instead because it's delta parameter is clearer
than a factor.
@Stormheg Stormheg merged commit f0a8471 into wagtail:main Sep 13, 2024
7 checks passed
@Stormheg Stormheg deleted the fix/wand-test branch September 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants