Fix NUMBER_PATTERN regex for parsing SVG viewboxes
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
Aug 4, 2023
| # https://github.com/wagtail/Willow/issues/127 | ||
| ( | ||
| "-5.000000011410315e-06 0.0 750.00001 525.000007", | ||
| ViewBox(-5.000000011410315e-06, 0.0, 750.00001, 525.000007), |
There was a problem hiding this comment.
can you add a test for -5.000000011410315e06 which should be valid as far as I can tell from https://www.w3.org/TR/SVG11/types.html#DataTypeNumber and https://www.w3.org/TR/SVG11/types.html#DataTypeInteger ?
Other than that, LGTM
There was a problem hiding this comment.
Good point, added a few more tests.
zerolab
approved these changes
Aug 4, 2023
zerolab
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
The
NUMBER_PATTERNin the SVG viewbox regular expression was missing the optional+or-in the final integer production.The definition for
number, as used in SVG attributes, can be found here: