Unify Error Handling #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
msporny,
martyr280 and
seabass-labrax
as code owners
Wind4Greg
requested review from
dlongley,
TallTed and
msporny
and removed request for
msporny,
martyr280 and
seabass-labrax
dlongley
approved these changes
Jun 24, 2024
TallTed
requested changes
Jun 24, 2024
index.html
Outdated
| </li> | ||
| <li> | ||
| If |proofConfig|.|created| is set and if the value is not a | ||
| valid [[XMLSCHEMA11-2]] datetime, an `INVALID_PROOF_DATETIME` error MUST be | ||
| raised. | ||
| valid [[XMLSCHEMA11-2]] datetime, an an error MUST be raised and SHOULD convey |
There was a problem hiding this comment.
Suggested change
| valid [[XMLSCHEMA11-2]] datetime, an an error MUST be raised and SHOULD convey | |
| valid [[XMLSCHEMA11-2]] datetime, an error MUST be raised and SHOULD convey |
There was a problem hiding this comment.
I got some weird GitHub errors when trying to batch in all the changes. So had to do it in two batches.
…r consistency and clarity. Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Dave Longley <[email protected]>
…r consistency and clarity. Co-authored-by: Ted Thibodeau Jr <[email protected]>
msporny
approved these changes
Jun 30, 2024
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
TallTed
added a commit
that referenced
this pull request
Jul 1, 2024
- delete now-errant line
- fix "ensure" phrasing — note: this sentence may need further work, as it's not clear whether confirming `an array of five elements` is sufficient to populate `the five elements` --
```
Initialize |components| to an array that is the result of CBOR-decoding the
bytes that follow the three-byte ECDSA-SD base proof header. Ensure the result
is an array of five elements.
</li>
<li>
Return an object with properties set to the five elements, using the names
`baseSignature`, `publicKey`, `hmacKey`, `signatures`, and `mandatoryPointers`,
respectively.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #63. It unifies error codes, error handling language, and adds error codes where needed.
Preview | Diff