Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate poison datasets in ECDSA when canonicalizing. #21

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Mitigate poison datasets in ECDSA when canonicalizing. #21

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01dd438
Mitigate poison datasets when canonicalizing.
msporny Jul 24, 2023
0b489fa
Fix grammar in poison graph section.
msporny Aug 5, 2023
973728e
Slightly reword RDF-CANON poison graph detection requirement.
msporny Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,12 @@ <h3>ecdsa-2019</h3>
section also include the verification of such a data integrity proof.
</p>

<p class="advisement">
When the RDF Dataset Canonicalization Algorithm [[RDF-CANON]] is utilized,
msporny marked this conversation as resolved.
Show resolved Hide resolved
implementations MUST detect <a data-cite="RDF-CANON#dataset-poisoning">
dataset poisoning</a> by default and abort processing.
msporny marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementations MUST detect <a data-cite="RDF-CANON#dataset-poisoning">
dataset poisoning</a> by default and abort processing.
implementations MUST ensure that, by default, <a data-cite="RDF-CANON#dataset-poisoning">
poison datasets</a> are detected and not processed.

The current wording emphasizes the responsibility of the caller of the RDFC-1.0 algorithm. But in rdf-canon, we encourage implementers of that algorithm to abort when they detect a poison dataset. So most users would only have to check that the RDFC-10 implementation they are using has the appropriate default for them, or set the mitigation parameters. Of course, in some situations, they may need to detect poison graph themselves...

Copy link
Member Author

@msporny msporny Aug 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0b489fa.

</p>

<section>
<h4>Add Proof (ecdsa-2019)</h4>

Expand Down