refactor: small refactor

vwh · Oct 16, 2024 · a04378b · a04378b
1 parent 7428173
commit a04378b
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 17 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -24,7 +24,6 @@ const areEqual = (
   return prevProps.isDatabaseLoaded === nextProps.isDatabaseLoaded;
 };
 
-// Memoize DBTable with custom comparison function
 const MemoizedDBTable = memo<DBTableProps>(DBTable, areEqual);
 const MemoizedUploadFile = memo(UploadFile);
 const MemoizedUrlFetch = memo(UrlFetch);

diff --git a/src/components/database/page-select.tsx b/src/components/database/page-select.tsx
@@ -25,6 +25,7 @@ export default function PageSelect({
     () => Math.ceil(totalRows / rowsPerPage),
     [totalRows, rowsPerPage]
   );
+
   const currentPage = useMemo(
     () => Math.ceil(page / rowsPerPage) + 1,
     [page, rowsPerPage]

diff --git a/src/components/database/query-textarea.tsx b/src/components/database/query-textarea.tsx
@@ -198,7 +198,6 @@ export default function QueryTextarea({ columnNames }: QueryTextareaProps) {
   return (
     <CodeMirror
       value={sqlQuery}
-      defaultValue={sqlQuery}
       height="126px"
       extensions={extensions}
       onChange={handleChange}

diff --git a/src/components/database/upper-section.tsx b/src/components/database/upper-section.tsx
@@ -4,11 +4,11 @@ import { useQueryData } from "@/hooks/useQueryData";
 import { usePagination } from "@/hooks/usePagination";
 
 import { Button } from "@/components/ui/button";
+import StatusMessage from "@/components/stats-message";
+import ExportButtons from "@/components/settings/export-buttons";
 import PageSelect from "./page-select";
 import TableSelect from "./table-select";
 import DBTableComponent from "./table-data";
-import StatusMessage from "@/components/stats-message";
-import ExportButtons from "@/components/settings/export-buttons";
 import QueryTextarea from "./query-textarea";
 
 import {
@@ -32,7 +32,6 @@ export default function DBTable() {
     rowPerPageOrAuto,
     isCustomQuery,
     setIsCustomQuery,
-    customQuery,
     setCustomQuery,
     expandPage,
     setExpandPage,
@@ -60,7 +59,7 @@ export default function DBTable() {
     if (columns.length > 0) {
       setSavedColumns(columns);
     }
-  }, [selectedTableName, columns]);
+  }, [columns]);
 
   const handleQueryRemove = useCallback(() => {
     setQueryError(null);
@@ -116,14 +115,7 @@ export default function DBTable() {
         </div>
       </div>
     ),
-    [
-      customQuery,
-      handleCustomQuery,
-      handleQueryRemove,
-      handleResetPage,
-      page,
-      savedColumns
-    ]
+    [handleCustomQuery, handleQueryRemove, handleResetPage, page, savedColumns]
   );
 
   const MemoizedTableContent = useMemo(() => {
@@ -150,7 +142,6 @@ export default function DBTable() {
     columns,
     selectedTableName,
     tableSchemas,
-    filters,
     savedColumns
   ]);
 
@@ -164,7 +155,6 @@ export default function DBTable() {
       <div className="flex flex-col gap-3 pb-8">
         <section className="rounded-lg bg-gray-100 p-4 shadow-sm dark:bg-gray-700">
           <div className="mb-[5px] flex items-center justify-between gap-1">
-            {/* Use MemoizedTableSelect instead of TableSelect */}
             <MemoizedTableSelect />
             <div className="flex items-center justify-center gap-1">
               {MemoizedExportButtonsComponent}

diff --git a/src/components/settings/theme-mode-toggle.tsx b/src/components/settings/theme-mode-toggle.tsx
@@ -67,7 +67,7 @@ export default function ThemeModeToggle() {
         )}
       </Button>
     ),
-    [theme]
+    [theme, toggleTheme]
   );
 
   return MemoizedThemeButton;