Check for null href in Headlink::itemToString function #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks, @LuomaJuha!
I think the issue with the previous PR is that you rebased all the commits on the dev branch onto release-10.0, instead of just the new commits from your branch. It's easy to do!
I confess that I tend to just create a new branch from release-10.0 and cherry-pick commits onto it because I find that easiest to remember... but it's also possible to use git rebase --onto if you're feeling adventurous. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided that creating a new branch from release-10 was the easiest as the rebase started to go into so many directions. :D