Improved RIS export

[damien-git]

This PR adds additional tags to the RIS export. A number of them are based on new SolrMarc functions, so they are specific to this driver.

New tags:

• ST (short title)
• L4 (page URL as an attachment)
• AB (abstract)
• AV (notes)
• CN (call number)
• J2 (alternate title)

Updated tags:

• KW (keywords - from the topics/subjects; getTopics was not implemented before)
• DO (DOI identifier, removing markup from EDS)

There might be ways to improve the way this implementation works with other drivers...

[demiankatz]

Thanks, @damien-git -- this looks like a significant improvement. I have a few suggested adjustments/improvements; see below.

[demiankatz]

What if you replaced the $indNum and $indValue parameters with a single array of indicator filters, and then any rows that match a filter will be allowed through? This way, instead of doing array merging in some of the functions below, you could request everything at once -- e.g.

        return array_merge(
            $this->getMarcFieldWithInd('520', null, '1', ''),
            $this->getMarcFieldWithInd('520', null, '1', '0'),
            $this->getMarcFieldWithInd('520', null, '1', '2'),
            $this->getMarcFieldWithInd('520', null, '1', '3'),
            $this->getMarcFieldWithInd('520', null, '1', '8'),
        );

becomes:

        return $this->getMarcFieldWithInd('520', null, [['1' => ''], ['1' => '0'], ['1' => '2'], ['1' => '3'], ['1' => '8']]);

Of course, there are other ways you could slice this... I'm just thinking the "array of arrays" approach might be more flexible since it would allow you to specify patterns that match two indicators at once if that need should arise.

[demiankatz]

I guess you could set things up so the array could include an array of values, meaning "any of these" and that would reduce it down to:

return $this->getMarcFieldWithInd('520', null, [['1' => ['', '0', '2', '3', '8']]]);

[meganschanz]

Good suggestion! I did that refactoring and added some unit tests to get SolrMarc.php back to 100% coverage.