This repository has been archived by the owner on Dec 26, 2018. It is now read-only.
Apply hotfix to support SSR (Fixes #92) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty messy, since this should be done in /src/component, however there's no contribution guide laying out the pre-processing steps. Don't really wanna bother with this too much either, [since it'll (hopefully) get patched on Hammer.js' side soon](hammerjs/hammer.js#1060)
|
+1 |
hwaphon
approved these changes
Feb 26, 2018
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this direct hotfix for
windownot being available server-sided. It's been 9 months since the PR for this has been proposed, so I think that 'temporary' fix in the readme should be implemented directly for the time being.Functionally, this does the same as the proposed readme fix:
window is not defined), it assigns an empty stub toHammerinsteadIt's not the most beautiful fix, but better than workarounds with webpack that don't work on certain setups.