Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom directive v2 #278

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: custom directive v2 #278

wants to merge 6 commits into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 19, 2024

Simplify custom directive API to match the template ref API.

Waiting a formal RFC

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 0ad2d25
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66f1caa7c5c66a0008a1c93a
😎 Deploy Preview https://deploy-preview-278--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 0ad2d25
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66f1caa79e0ae100088f8bbf
😎 Deploy Preview https://deploy-preview-278--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 19, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 59 kB 19.7 kB 17.8 kB
runtime-dom.global.prod.js 101 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 47.5 kB (+1.51 kB) 17.9 kB (+702 B) 16.4 kB (+632 B)
vue-vapor.global.prod.js 103 kB (+1.51 kB) 36 kB (+684 B) 32.4 kB (+564 B)
vue.global.prod.js 160 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.4 kB 19 kB 17.3 kB
createApp 56 kB 21.4 kB 19.6 kB
createSSRApp 60 kB 23.1 kB 21.1 kB
defineCustomElement 60.8 kB 23 kB 21 kB
vapor 48.2 kB (+1.51 kB) 18.1 kB (+693 B) 16.6 kB (+620 B)
overall 69.7 kB 26.5 kB 24.1 kB

@LittleSound
Copy link
Member

Great. I had this idea before. Thanks for starting it

can you explain how this API behaves differently from before?

@sxzz sxzz marked this pull request as draft September 21, 2024 18:33
Copy link

pkg-pr-new bot commented Sep 22, 2024

Open in Stackblitzplayground

@vue/compiler-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-core@278

@vue/compiler-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-dom@278

@vue/compiler-sfc

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-sfc@278

@vue/compiler-ssr

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-ssr@278

@vue/reactivity

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/reactivity@278

@vue/compiler-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-vapor@278

@vue/runtime-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-core@278

@vue/runtime-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-dom@278

@vue/runtime-shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-shared@278

@vue/runtime-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-vapor@278

@vue/server-renderer

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/server-renderer@278

@vue/shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/shared@278

@vue/compat

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compat@278

vue

pnpm add https://pkg.pr.new/vuejs/core-vapor/vue@278

@vue/vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/vapor@278

commit: 0ad2d25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants